Review main Merged

56027[BUGFIX] Call only clickOnLabel() in SVG based trees

Andreas Kienast CR +2 V +2 Easy +0 −6 updated 03/07/18, 08:33

Commit message

SVG based trees have a method called `clickOnLabel()`, which internally
calls `selectNode()` and also triggers a click event in `nodeBgEvents()`.

However, the latter two calls are repeated after `clickOnLabel()` is
called, causing issues like asking "Do you want to quit without saving?"
twice.

The calls are superfluous and are removed.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • Paweł Rogowicz +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Mathias Schreiber +1
    • Markus Klein +1
    • Riccardo De Contardi +1
    • Paweł Rogowicz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 03/06/18, 20:12

  2. Andreas Kienast updated the commit message in patch set 2 03/06/18, 20:18

  3. Markus Klein commented on patch set 2 V +1 CR +1 03/06/18, 20:21

    no-brainer
  4. TYPO3com voted on patch set 1 V +1 03/06/18, 20:22 Completed build in 09m 17s on Tue, 6 Mar, 09:22 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20595

  5. Riccardo De Contardi commented on patch set 2 V +1 03/06/18, 20:26

    tested with the following procedure: - open a CE, change the title, click on another page of pagetree.
  6. TYPO3com voted on patch set 2 V +1 03/06/18, 20:27 Completed build in 08m 57s on Tue, 6 Mar, 09:27 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20596

  7. Mathias Schreiber voted on patch set 2 V +1 CR +1 03/06/18, 20:40

  8. Paweł Rogowicz voted on patch set 2 V +1 CR +1 03/07/18, 07:50

  9. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 03/07/18, 08:33

  10. Tymoteusz Motylewski merged patch set 3 03/07/18, 08:33