Review main Merged

56041[BUGFIX] Expose interfaces of AjaxDataHandler

Andreas Kienast CR +2 V +2 Normal +71 −17 updated 03/16/18, 09:47

Commit message

Since the AjaxDataHandler is meant to be used in other modules as well,
the interfaces responsible for the response and the messages need to be
public to be able to write type-safe callbacks.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1316

  1. Andreas Kienast uploaded patch set 1 03/07/18, 20:02

  2. TYPO3com voted on patch set 1 V +1 03/07/18, 20:11 Completed build in 08m 36s on Wed, 7 Mar, 09:11 PM Test Summary: 30812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20649

  3. Oliver Hader voted on patch set 1 CR +1 03/07/18, 20:36

  4. Wouter Wolters voted on patch set 1 CR +1 03/08/18, 11:04

  5. Georg Ringer voted on patch set 1 CR +1 03/08/18, 12:29

  6. Mathias Schreiber updated the commit message in patch set 2 03/08/18, 12:35

  7. Mathias Schreiber voted on patch set 2 V +1 CR +1 03/08/18, 12:35

  8. TYPO3com voted on patch set 2 V +1 03/08/18, 12:44 Completed build in 09m 18s on Thu, 8 Mar, 01:44 PM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20683

  9. Oliver Hader voted on patch set 2 CR +1 03/08/18, 15:09

  10. Frank Nägler commented on patch set 2 CR -1 03/15/18, 20:56

    will discuss the solution with Andy, temp -1
  11. Andreas Kienast uploaded patch set 3 03/16/18, 07:45

  12. TYPO3com voted on patch set 3 V +1 03/16/18, 07:54 Completed build in 08m 40s on Fri, 16 Mar, 08:54 AM Test Summary: 30879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21171

  13. Frank Nägler voted on patch set 3 CR +1 03/16/18, 09:25

  14. Frank Nägler voted on patch set 3 V +1 03/16/18, 09:31

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 03/16/18, 09:47

  16. Christian Kuhn merged patch set 4 03/16/18, 09:47