Review main Abandoned

56044[BUGFIX] Check registry for upgrade wizard report

Jigal van Hemert CR 0 V 0 Easy +4 −1 updated 03/08/18, 07:20

Commit message

In the Reports module the check for unfinished upgrade wizards also
checks the registry to see if a wizard is marked as done. Upgrade
wizards can be marked as done even if their function
shouldRenderWizard() indicates that they are not finished.
The Reports module now shows the same status as the Install Tool.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Jigal van Hemert uploaded patch set 1 03/07/18, 22:01

  2. TYPO3com voted on patch set 1 V +1 03/07/18, 22:09 Completed build in 08m 19s on Wed, 7 Mar, 11:09 PM Test Summary: 30812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20655

  3. Christian Kuhn voted on patch set 1 CR +1 03/07/18, 22:27

  4. Christian Kuhn voted on patch set 1 V -1 CR 0 03/07/18, 23:35

  5. Christian Kuhn commented on patch set 1 CR -1 03/07/18, 23:56

    Jigal, I neither can reproduce the issue in master, nor I understand your solution: The install tool decides based on "shouldRenderWizards()" returning true if a wizard should be rendered. See UpgradeWizardsService ~274 (and js processing in UpgradeWizards.js ~271). That is exactly the same method as called by the reports module. shouldRenderWizards() then sometimes (for those wizards that *are* registered as done in registry) calls isWizardDone() of AbstractUpdate which performs the exact same check you're doing in InstallStatusReport now, so this is bogus. Which specific wizard creates the issue for you in master, and how did you reproduce? The internal logic might be slightly different in v8, and maybe this has been fixed in master with the install tool rewrite already, the upgrade wizards logic has been simplified a bit in master. So, the fix might be ok for 8.7 maybe, but for master, I can't find a logical path that needs this registry call. So, how did you reproduce the issue in master? If we sort that out for master, we may then have a second look at v8 afterwards.
  6. Jigal van Hemert abandoned the change 03/08/18, 07:20

    Only relevant for v8