Review main Merged

56054[BUGFIX] Do not mark "current" links as broken

Susi Moog CR +2 V +2 Easy +1 −1 updated 03/09/18, 00:23

Commit message

The linkhandler can resolve pages by uid or by using the
special keyword "current" which links the current page id.

The RteHtmlParser marked links to "current" as broken as the check
on whether the page record exists fails with a non-int uid.

The check has been disabled for links to the current page, as in that
context "current" has to be a valid page record (else content could
not be edited on it).

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Susi Moog uploaded patch set 1 03/08/18, 09:56

  2. Wouter Wolters voted on patch set 1 CR +1 03/08/18, 10:01

  3. TYPO3com voted on patch set 1 V +1 03/08/18, 10:06 Completed build in 09m 41s on Thu, 8 Mar, 11:06 AM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20678

  4. Mathias Schreiber voted on patch set 1 V +1 CR +1 03/08/18, 11:42

  5. Michael Oehlhof voted on patch set 1 V +1 CR +1 03/08/18, 22:20

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/09/18, 00:23

  7. Christian Kuhn merged patch set 2 03/09/18, 00:23

  8. Christian Kuhn commented on patch set 2 03/09/18, 00:23

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 6a6b8107febb318afdc347d12355fb704e99599e