Review TYPO3_8-7 Merged

56056[BUGFIX] Catch all exceptions in page module of form framework

Christian Kuhn CR +2 V +2 Easy +9 −2 updated 03/08/18, 11:01

Commit message

Catch the toplevel \Exception within the preview renderer hook. This
prevents that the page module shows an exception stacktrace if a
formDefinition - which is referenced within a form plugin - is moved
manually to a different location.
The problem occurs because the TYPO3\CMS\Core\Resource\Driver\LocalDriver
throws some top level exceptions (e.g. within getFileInfoByIdentifier()).

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn commented on patch set 1 03/08/18, 10:44

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/08/18, 11:00 Completed build in 15m 41s on Thu, 8 Mar, 12:00 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2044

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 03/08/18, 11:00

  4. Christian Kuhn merged patch set 2 03/08/18, 11:01