Review main Merged

56058[BUGFIX] Update local cache upon creation of new storage object

Bernhard Kraft CR +2 V +2 Easy +3 −0 updated 10/28/18, 16:54

Commit message

When a new storage object for the "local" driver is being created
it is not possible to retrieve the new object instantaneous. The
objects are being cached in a local static variable which needs
to get flushed (set to "null") first.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1317

  1. Bernhard Kraft uploaded patch set 1 03/08/18, 12:45

  2. TYPO3com voted on patch set 1 V +1 03/08/18, 12:55 Completed build in 09m 28s on Thu, 8 Mar, 01:55 PM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20686

  3. Markus Klein commented on patch set 1 03/08/18, 12:57

    StorageRepository.php:129

    These are not necessary anymore
  4. Bernhard Kraft uploaded patch set 2 03/08/18, 14:26

  5. Bernhard Kraft commented on patch set 2 03/08/18, 14:29

    Makes sense. Reinitializing the cache would only make sense if retrieveing something from the resourceStorage afterwards. But in all findBy* methods the cache gets initialized anyways. Removed the unnecessary time consuming method call from this line.
  6. TYPO3com voted on patch set 2 V +1 03/08/18, 14:37 Completed build in 10m 17s on Thu, 8 Mar, 03:37 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20695

  7. Markus Klein commented on patch set 2 03/08/18, 18:10

    StorageRepository.php:127

    this is still superfluous here
  8. Benni Mack commented on patch set 2 09/17/18, 14:13

    ping
  9. Bernhard Kraft uploaded patch set 3 10/18/18, 19:09

  10. TYPO3com voted on patch set 3 V -1 10/18/18, 19:21 Completed build in 11m 45s on Thu, 18 Oct, 09:21 PM Test Summary: 2433 of 38088 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29483

  11. Frans Saris voted on patch set 3 CR +1 10/20/18, 13:04

  12. Benni Mack uploaded patch set 4 10/28/18, 16:37

  13. Benni Mack voted on patch set 4 V +1 CR +1 10/28/18, 16:38

  14. Wouter Wolters voted on patch set 4 CR +1 10/28/18, 16:46

  15. TYPO3com voted on patch set 4 V +1 10/28/18, 16:50 Completed build in 13m 08s on Sun, 28 Oct, 05:50 PM Test Summary: 38167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29789

  16. Wouter Wolters voted on patch set 4 V +2 CR +2 10/28/18, 16:54

  17. Wouter Wolters merged patch set 5 10/28/18, 16:54