Review TYPO3_8-7 Merged

56066[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element

Susi Moog CR +2 V +2 Easy +2 −0 updated 03/12/18, 16:29

Commit message

Review

  • Code review CR +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Susi Moog commented on patch set 1 03/08/18, 16:15

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/08/18, 16:32 Completed build in 16m 33s on Thu, 8 Mar, 05:32 PM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2052

  3. Stefan Neufeind uploaded patch set 2 03/12/18, 14:19

  4. Stefan Neufeind commented on patch set 2 CR +1 03/12/18, 14:24

    resolved merge-conflict; ImageUpload also has a "class=..."-line (also on master - separate to this patch here)
  5. TYPO3com voted on patch set 2 V +1 03/12/18, 14:35 Completed build in 15m 31s on Mon, 12 Mar, 03:35 PM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2081

  6. Oliver Hader voted on patch set 2 CR +1 03/12/18, 14:35

  7. Susi Moog voted on patch set 2 V +1 CR +1 03/12/18, 16:28

  8. Oliver Hader voted on patch set 2 V +2 CR +2 03/12/18, 16:28

  9. Oliver Hader merged patch set 3 03/12/18, 16:29