Review main Merged

56071[BUGFIX] Proper returnUrl editing permissions from context menu

Christian Kuhn CR +2 V +2 Easy +6 −1 updated 03/09/18, 08:32

Commit message

Context menu on pages -> More options -> Access call the
permissions module without proper returnUrl, doc header
"save and close" then fails redirecting to last view.
Fix using similar tec as used in other places like filelist
by providing a proper returnUrl.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 03/09/18, 00:11

  2. Christian Kuhn updated the commit message in patch set 2 03/09/18, 00:19

  3. TYPO3com voted on patch set 1 V +1 03/09/18, 00:20 Completed build in 08m 31s on Fri, 9 Mar, 01:20 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20725

  4. TYPO3com voted on patch set 2 V +1 03/09/18, 00:30 Completed build in 11m 43s on Fri, 9 Mar, 01:30 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20726

  5. Susi Moog voted on patch set 2 V +1 CR +1 03/09/18, 08:24

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 03/09/18, 08:32

  7. Andreas Kienast merged patch set 3 03/09/18, 08:32

  8. Andreas Kienast commented on patch set 3 03/09/18, 08:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 05ca5521681400e6a03cf7538c26ca91e7f1e9a8