Review TYPO3_8-7 Merged

56072[BUGFIX] Do not mark "current" links as broken

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 03/09/18, 00:46

Commit message

The linkhandler can resolve pages by uid or by using the
special keyword "current" which links the current page id.

The RteHtmlParser marked links to "current" as broken as the check
on whether the page record exists fails with a non-int uid.

The check has been disabled for links to the current page, as in that
context "current" has to be a valid page record (else content could
not be edited on it).

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 36

  1. Christian Kuhn commented on patch set 1 03/09/18, 00:23

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/09/18, 00:37 Completed build in 14m 18s on Fri, 9 Mar, 01:37 AM Test Summary: 2 of 58499 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2056

  3. TYPO3com commented on patch set 1 03/09/18, 00:45 Completed build in 36m 36s on Fri, 9 Mar, 01:45 AM Test Summary: 1 of 58499 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2056

  4. TYPO3com voted on patch set 1 V +1 03/09/18, 00:46 Completed build in 59m 45s on Fri, 9 Mar, 01:46 AM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2056

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/09/18, 00:46

  6. Christian Kuhn merged patch set 2 03/09/18, 00:46