56073[FEATURE] Add column selector to filelist
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Feature-84184-ShowColumnsSelectionInFilelist.rstnew+38 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+2 −2
- typo3/sysext/filelist/Classes/Controller/FileListController.php2+17 −0
- typo3/sysext/filelist/Classes/FileList.php7+117 −36
- typo3/sysext/filelist/Resources/Private/Language/locallang_mod_file_list.xlf+3 −9
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html2+31 −7
- typo3/sysext/recordlist/Classes/Controller/ColumnSelectorController.php+68 −13
Review log 2845
Show 1320 earlier messages
-
Wolfgang Klinger uploaded patch set 1 03/09/18, 07:16
-
TYPO3com voted on patch set 1 V +1 03/09/18, 07:25 Completed build in 09m 21s on Fri, 9 Mar, 08:25 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20729
-
Wolfgang Klinger uploaded patch set 2 04/06/18, 19:20
-
TYPO3com voted on patch set 2 V +1 04/06/18, 19:31 Completed build in 10m 11s on Fri, 6 Apr, 09:31 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22164
-
Wolfgang Klinger uploaded patch set 3 04/06/18, 19:57
-
TYPO3com voted on patch set 3 V +1 04/06/18, 20:06 Completed build in 09m 14s on Fri, 6 Apr, 10:06 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22169
-
Wolfgang Klinger uploaded patch set 4 04/06/18, 20:12
-
Wolfgang Klinger updated the commit message in patch set 5 04/06/18, 20:13
-
TYPO3com voted on patch set 4 V +1 04/06/18, 20:22 Completed build in 09m 55s on Fri, 6 Apr, 10:22 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22171
-
TYPO3com voted on patch set 5 V +1 04/06/18, 20:23 Completed build in 10m 07s on Fri, 6 Apr, 10:23 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22172
-
Mathias Schreiber commented on patch set 5 V -1 CR -1 04/08/18, 14:16
Blocking until the release of 9.2. If I forget to release the block until April 11th, please ping me. -
Wolfgang Klinger commented on patch set 5 04/12/18, 09:19
ping ping ping -
Benni Mack commented on patch set 5 10/29/18, 16:20
FileList.php:729if I read the code, this else clause is never reached. -
Wolfgang Klinger uploaded patch set 6 11/25/18, 16:23
-
TYPO3com voted on patch set 6 V +1 11/25/18, 16:34 Completed build in 10m 44s on Sun, 25 Nov, 05:34 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30276
-
Guido Schmechel commented on patch set 6 12/08/18, 09:47
Test with htmlcontent => htmlspecialchars and length is ok Field categories shows only a number. Do we need a commaseparated category list? Untested: What happens to fields that have been added by other extensions?Feature-84184-AddFieldSelectToFilelist.rst:14UnresolvedMaybe it was helpful if we list here the "new" fields? -
Georg Ringer commented on patch set 6 CR -1 11/01/19, 19:20
FileListController.php:630Unresolvedplease remove that, the phpstorm plugin DynamicReturnType takes care of suchFileListController.php:635Unresolvedplease remove, see upoveFileList.php:578Unresolvedwe don't do columns, only 1 whitespaceFileList.php:582Unresolved: stringFileList.php:658Unresolved:void -
Daniel Goerz commented on patch set 6 CR -1 01/22/20, 15:48
FileList.php:582Unresolvedwhy public?FileList.php:682Unresolvedthis is just copied from DatabaseRecordList why public?FileList.php:730Unresolvednamespace LogManager is not imported -
Benni Mack uploaded patch set 7 07/09/21, 09:37
-
core-ci voted on patch set 7 V -1 07/09/21, 09:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13128
-
Benni Mack uploaded patch set 8 08/23/21, 14:08
-
core-ci voted on patch set 8 V -1 08/23/21, 14:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15412
-
Benni Mack uploaded patch set 9 08/23/21, 16:36
-
core-ci voted on patch set 9 V +1 08/23/21, 16:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15422
-
Simon Schaufelberger commented on patch set 9 08/24/21, 19:37
List.html:81a few lines below the inline notation is used. What is the preferred way? -
Oli Bartsch uploaded patch set 10 08/25/21, 00:07
-
core-ci voted on patch set 10 V +1 08/25/21, 00:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15549
-
Oli Bartsch uploaded patch set 11 08/25/21, 01:06
-
core-ci voted on patch set 11 V +1 08/25/21, 01:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15553
-
Oli Bartsch uploaded patch set 12 08/25/21, 10:35
-
core-ci voted on patch set 12 V -1 08/25/21, 10:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15577
-
Oli Bartsch updated the commit message in patch set 13 08/25/21, 10:39
-
Oli Bartsch uploaded patch set 14 08/25/21, 10:43
-
core-ci voted on patch set 13 V -1 08/25/21, 10:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15578
-
core-ci voted on patch set 14 V +1 08/25/21, 10:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15579
-
Benni Mack commented on patch set 14 08/25/21, 12:33
List.html:81ReplyThere is no recommendation, and everybody is free to use what they please. I personally use the XML-based syntax if not within an attribute, but this is more a personal taste. -
Oli Bartsch uploaded patch set 15 08/25/21, 12:37
-
core-ci voted on patch set 15 V +1 08/25/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15593
-
Oli Bartsch uploaded patch set 16 08/25/21, 17:33
-
core-ci voted on patch set 16 V +1 08/25/21, 17:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15617
-
Oli Bartsch uploaded patch set 17 08/25/21, 19:53
-
core-ci voted on patch set 17 V +1 08/25/21, 20:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15625
-
Oli Bartsch voted on patch set 17 V +1 CR +1 08/25/21, 20:13
-
Benni Mack commented on patch set 17 V +2 CR +2 08/25/21, 20:15
Finally we have this feature included! -
Benni Mack merged patch set 18 08/25/21, 20:15