Review main Merged

56073[FEATURE] Add column selector to filelist

Wolfgang Klinger CR +2 V +2 Hard +276 −67 updated 08/25/21, 20:15

Commit message

This adds the column selector component,
introduced in #94218, to the filelist module.

As known from recordlist, it can be used to
manage the fields to be displayed for each
file / folder. Fields to be selected are the
combination of special fields (e.g. read/write
permissions), sys_file fields and sys_file_metadata
fields.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2845

Show 1320 earlier messages
  1. Wolfgang Klinger uploaded patch set 1 03/09/18, 07:16

  2. TYPO3com voted on patch set 1 V +1 03/09/18, 07:25 Completed build in 09m 21s on Fri, 9 Mar, 08:25 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20729

  3. Wolfgang Klinger uploaded patch set 2 04/06/18, 19:20

  4. TYPO3com voted on patch set 2 V +1 04/06/18, 19:31 Completed build in 10m 11s on Fri, 6 Apr, 09:31 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22164

  5. Wolfgang Klinger uploaded patch set 3 04/06/18, 19:57

  6. TYPO3com voted on patch set 3 V +1 04/06/18, 20:06 Completed build in 09m 14s on Fri, 6 Apr, 10:06 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22169

  7. Wolfgang Klinger uploaded patch set 4 04/06/18, 20:12

  8. Wolfgang Klinger updated the commit message in patch set 5 04/06/18, 20:13

  9. TYPO3com voted on patch set 4 V +1 04/06/18, 20:22 Completed build in 09m 55s on Fri, 6 Apr, 10:22 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22171

  10. TYPO3com voted on patch set 5 V +1 04/06/18, 20:23 Completed build in 10m 07s on Fri, 6 Apr, 10:23 PM Test Summary: 30918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22172

  11. Mathias Schreiber commented on patch set 5 V -1 CR -1 04/08/18, 14:16

    Blocking until the release of 9.2. If I forget to release the block until April 11th, please ping me.
  12. Wolfgang Klinger commented on patch set 5 04/12/18, 09:19

    ping ping ping
  13. Benni Mack commented on patch set 5 10/29/18, 16:20

    FileList.php:729

    if I read the code, this else clause is never reached.
  14. Wolfgang Klinger uploaded patch set 6 11/25/18, 16:23

  15. TYPO3com voted on patch set 6 V +1 11/25/18, 16:34 Completed build in 10m 44s on Sun, 25 Nov, 05:34 PM Test Summary: 48484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30276

  16. Guido Schmechel commented on patch set 6 12/08/18, 09:47

    Test with htmlcontent => htmlspecialchars and length is ok Field categories shows only a number. Do we need a commaseparated category list? Untested: What happens to fields that have been added by other extensions?

    Feature-84184-AddFieldSelectToFilelist.rst:14 Unresolved

    Maybe it was helpful if we list here the "new" fields?
  17. Georg Ringer commented on patch set 6 CR -1 11/01/19, 19:20

    FileListController.php:630 Unresolved

    please remove that, the phpstorm plugin DynamicReturnType takes care of such

    FileListController.php:635 Unresolved

    please remove, see upove

    FileList.php:578 Unresolved

    we don't do columns, only 1 whitespace

    FileList.php:582 Unresolved

    : string

    FileList.php:658 Unresolved

    :void
  18. Daniel Goerz commented on patch set 6 CR -1 01/22/20, 15:48

    FileList.php:582 Unresolved

    why public?

    FileList.php:682 Unresolved

    this is just copied from DatabaseRecordList why public?

    FileList.php:730 Unresolved

    namespace LogManager is not imported
  19. Benni Mack uploaded patch set 7 07/09/21, 09:37

  20. core-ci voted on patch set 7 V -1 07/09/21, 09:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13128

  1. Benni Mack uploaded patch set 8 08/23/21, 14:08

  2. core-ci voted on patch set 8 V -1 08/23/21, 14:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15412

  3. Benni Mack uploaded patch set 9 08/23/21, 16:36

  4. core-ci voted on patch set 9 V +1 08/23/21, 16:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15422

  5. Simon Schaufelberger commented on patch set 9 08/24/21, 19:37

    List.html:81

    a few lines below the inline notation is used. What is the preferred way?
  6. Oli Bartsch uploaded patch set 10 08/25/21, 00:07

  7. core-ci voted on patch set 10 V +1 08/25/21, 00:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15549

  8. Oli Bartsch uploaded patch set 11 08/25/21, 01:06

  9. core-ci voted on patch set 11 V +1 08/25/21, 01:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15553

  10. Oli Bartsch uploaded patch set 12 08/25/21, 10:35

  11. core-ci voted on patch set 12 V -1 08/25/21, 10:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15577

  12. Oli Bartsch updated the commit message in patch set 13 08/25/21, 10:39

  13. Oli Bartsch uploaded patch set 14 08/25/21, 10:43

  14. core-ci voted on patch set 13 V -1 08/25/21, 10:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15578

  15. core-ci voted on patch set 14 V +1 08/25/21, 10:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15579

  16. Benni Mack commented on patch set 14 08/25/21, 12:33

    List.html:81 Reply

    There is no recommendation, and everybody is free to use what they please. I personally use the XML-based syntax if not within an attribute, but this is more a personal taste.
  17. Oli Bartsch uploaded patch set 15 08/25/21, 12:37

  18. core-ci voted on patch set 15 V +1 08/25/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15593

  19. Oli Bartsch uploaded patch set 16 08/25/21, 17:33

  20. core-ci voted on patch set 16 V +1 08/25/21, 17:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15617

  21. Oli Bartsch uploaded patch set 17 08/25/21, 19:53

  22. core-ci voted on patch set 17 V +1 08/25/21, 20:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15625

  23. Oli Bartsch voted on patch set 17 V +1 CR +1 08/25/21, 20:13

  24. Benni Mack commented on patch set 17 V +2 CR +2 08/25/21, 20:15

    Finally we have this feature included!
  25. Benni Mack merged patch set 18 08/25/21, 20:15