Review main Merged

56089[BUGFIX] Unify the filename sanitation for upload, create, rename

Wolfgang Klinger CR +2 V +2 Easy +19 −11 updated 03/18/18, 11:51

Commit message

isValidFilename allows other characters in file names
than sanitizeFileName. This patch sanitizes new file
names automatically (like it’s done for uploads) and
adds a warning for the user about the invalid original
file name for upload, create and rename.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
    • Frans Saris +1
    • Mathias Brodala +1
  • Verified V +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1622

  1. Wolfgang Klinger uploaded patch set 1 03/09/18, 22:42

  2. TYPO3com voted on patch set 1 V +1 03/09/18, 22:51 Completed build in 09m 01s on Fri, 9 Mar, 11:51 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20773

  3. Wolfgang Klinger uploaded patch set 2 03/10/18, 05:57

  4. TYPO3com voted on patch set 2 V -1 03/10/18, 06:06 Completed build in 08m 38s on Sat, 10 Mar, 07:06 AM Test Summary: 1 of 30989 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20778

  5. TYPO3com voted on patch set 2 V +1 03/10/18, 07:50 Completed build in 2h 01m 28s on Sat, 10 Mar, 08:50 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20778

  6. Jörg Bösche voted on patch set 2 CR +1 03/12/18, 08:03

  7. Mathias Brodala commented on patch set 2 03/12/18, 08:15

    Thanks for tackling this!

    fileMessages.xlf:79

    Can you add a '.. to "%s"' here?
  8. Tobi Kretschmann voted on patch set 2 CR +1 03/12/18, 08:39

  9. Mathias Brodala commented on patch set 3 03/12/18, 08:47

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 03/12/18, 08:55 Completed build in 08m 15s on Mon, 12 Mar, 09:55 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20820

  11. Mathias Brodala commented on patch set 4 03/12/18, 09:30

    Published edit on patch set 3.
  12. Mathias Brodala voted on patch set 4 V +1 CR +1 03/12/18, 09:32

  13. TYPO3com voted on patch set 4 V +1 03/12/18, 09:39 Completed build in 09m 19s on Mon, 12 Mar, 10:39 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20823

  14. Henning Liebe voted on patch set 4 CR +1 03/12/18, 10:58

  15. Frans Saris commented on patch set 4 CR -1 03/12/18, 22:16

    ExtendedFileUtility.php:827 Unresolved

    This log should also be adjusted

    ExtendedFileUtility.php:831 Unresolved

    Use `$resultObject->getName()` here

    ExtendedFileUtility.php:1089 Unresolved

    This log should also be adjusted

    ExtendedFileUtility.php:1090 Unresolved

    Here to
  16. Andreas Wolf uploaded patch set 5 03/17/18, 14:14

  17. TYPO3com voted on patch set 5 V +1 03/17/18, 14:29 Completed build in 14m 55s on Sat, 17 Mar, 03:29 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21482

  18. Anja Leichsenring voted on patch set 5 V +1 CR +1 03/18/18, 10:36

  19. Mathias Brodala voted on patch set 5 V +1 CR +1 03/18/18, 10:38

  20. Frans Saris voted on patch set 5 CR +1 03/18/18, 11:06

  21. Andreas Wolf voted on patch set 5 V +2 CR +2 03/18/18, 11:51

  22. Andreas Wolf merged patch set 6 03/18/18, 11:51