Review main Abandoned

56090[FEATURE] Add report for UTF8filesystem and Locale check

Wolfgang Klinger CR 0 V 0 Normal +52 −0 updated 03/15/18, 07:07

Commit message

Add a report that checks if the UTF8filesystem
and systemLocale settings match.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 911

  1. Wolfgang Klinger uploaded patch set 1 03/09/18, 23:18

  2. TYPO3com voted on patch set 1 V +1 03/09/18, 23:27 Completed build in 08m 41s on Sat, 10 Mar, 12:27 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20775

  3. Guido Schmechel voted on patch set 1 V +1 CR +1 03/10/18, 11:03

  4. Wouter Wolters commented on patch set 1 03/10/18, 12:13

    ConfigurationStatus.php:58 Unresolved

    ReportStatus is returned.
  5. Wolfgang Klinger uploaded patch set 2 03/10/18, 12:41

  6. TYPO3com voted on patch set 2 V +1 03/10/18, 12:50 Completed build in 09m 14s on Sat, 10 Mar, 01:50 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20783

  7. Markus Klein commented on patch set 2 03/10/18, 13:09

    Don't we have such a check in the Install Tool already? At least for empty locale there was a warning. Combine those somehow? Add the regex check there too?
  8. Wolfgang Klinger abandoned the change 03/10/18, 17:22

  9. Markus Klein commented on patch set 2 03/10/18, 18:40

    Why abandon?
  10. Wolfgang Klinger commented on patch set 2 03/11/18, 13:36

    I found a similar check in the Install Tool, as you mentioned.
  11. Georg Ringer commented on patch set 2 03/15/18, 07:07

    Feature-84193-ReportForCheckingUTF8FilesystemAndLocaleSettings.rst:13 Unresolved

    wrap in single quotes, also below

    ConfigurationStatus.php:60 Unresolved

    add return type hint