Review main Merged

56093[BUGFIX] PSR-7 responses return header using getHeader()

Christian Kuhn CR +2 V +2 Normal +118 −2 updated 05/13/18, 08:37

Commit message

The base PSR-7 implementation of the Response object does not
sanitize the headers properly when handing them in as an array,
thus, it is stored wrong in the Response object.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Wolf +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Wolf +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1217

  1. Christian Kuhn uploaded patch set 1 03/11/18, 06:06

  2. TYPO3com voted on patch set 1 V -1 03/11/18, 06:15 Completed build in 08m 00s on Sun, 11 Mar, 07:15 AM Test Summary: 12 of 31007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20796

  3. Susi Moog updated the commit message in patch set 2 03/13/18, 08:21

  4. Susi Moog commented on patch set 2 03/13/18, 08:23

    removed (?) from releases line as it broke forger.
  5. TYPO3com voted on patch set 2 V -1 03/13/18, 08:29 Completed build in 08m 31s on Tue, 13 Mar, 09:29 AM Test Summary: 12 of 31009 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20886

  6. Benni Mack uploaded patch set 3 03/21/18, 21:52

  7. TYPO3com voted on patch set 3 V +1 03/21/18, 22:01 Completed build in 08m 27s on Wed, 21 Mar, 11:01 PM Test Summary: 30894 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21767

  8. Benni Mack updated the commit message in patch set 4 04/25/18, 04:16

  9. TYPO3com voted on patch set 4 V +1 04/25/18, 04:24 Completed build in 08m 25s on Wed, 25 Apr, 06:24 AM Test Summary: 31070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22862

  10. Tymoteusz Motylewski commented on patch set 4 04/27/18, 20:39

    RedirectResponseTest.php:48

    what do you mean by this todo?
  11. Christian Kuhn uploaded patch set 5 05/13/18, 08:19

  12. TYPO3com voted on patch set 5 V +1 05/13/18, 08:27 Completed build in 07m 40s on Sun, 13 May, 10:27 AM Test Summary: 31129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23421

  13. Andreas Wolf voted on patch set 5 V +1 CR +1 05/13/18, 08:32

  14. Anja Leichsenring voted on patch set 5 V +1 CR +1 05/13/18, 08:36

  15. Christian Kuhn voted on patch set 5 V +2 CR +2 05/13/18, 08:36

  16. Christian Kuhn merged patch set 6 05/13/18, 08:36

  17. Christian Kuhn commented on patch set 6 05/13/18, 08:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 717100d36fe329b6ad2ee3f52618653da1171e65