56095[TASK] Add test coverage for RouteDispatcher
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Benni Mack +1
-
Verified V +2
- Anja Leichsenring +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 6
- typo3/sysext/backend/Classes/Http/RouteDispatcher.php+0 −2
- typo3/sysext/backend/Tests/Unit/Http/Fixtures/RouteDispatcherClassFixture.phpnew+31 −0
- typo3/sysext/backend/Tests/Unit/Http/Fixtures/RouteDispatcherClassInvokeFixture.phpnew+31 −0
- typo3/sysext/backend/Tests/Unit/Http/Fixtures/RouteDispatcherClassWithoutInvokeFixture.phpnew+22 −0
- typo3/sysext/backend/Tests/Unit/Http/Fixtures/RouteDispatcherStaticClassFixture.phpnew+31 −0
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.phpnew+265 −0
Review log 1013
-
Christian Kuhn uploaded patch set 1 03/11/18, 09:59
-
TYPO3com voted on patch set 1 V -1 03/11/18, 10:08 Completed build in 08m 16s on Sun, 11 Mar, 11:08 AM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20798
-
Christian Kuhn uploaded patch set 2 03/11/18, 10:12
-
TYPO3com voted on patch set 2 V +1 03/11/18, 10:22 Completed build in 09m 00s on Sun, 11 Mar, 11:22 AM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20799
-
Tobi Kretschmann voted on patch set 2 CR +1 03/19/18, 10:12
-
Benni Mack commented on patch set 2 03/19/18, 20:25
I'm glad you have a really nice solution for that issue that I actually introduced. However, I do have a recommendation.... how about we do this in the Bootstrap:initializeBackendRouter() call, so it is checked on initialization and only if core caches are emptied, and not when it is executed. So it is easier to spot when upgrading - plus it does not slow down every BE request due to reflection on every runtime. What do you think? -
Christian Kuhn commented on patch set 2 CR -1 03/21/18, 18:31
good idea benni. i'll try to come up with something. -
Tymoteusz Motylewski commented on patch set 2 03/29/18, 09:16
as long as -
Christian Kuhn uploaded patch set 3 06/09/18, 10:35
-
TYPO3com voted on patch set 3 V +1 06/09/18, 10:43 Completed build in 07m 42s on Sat, 9 Jun, 12:43 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24183
-
Benni Mack voted on patch set 3 V +1 CR +1 06/09/18, 10:50
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 06/09/18, 11:36
-
Anja Leichsenring merged patch set 4 06/09/18, 11:37