Review main Merged

56098[TASK] Move IRRE actions to a map and export inline

Andreas Kienast CR +2 V +2 Easy +18 −6 updated 03/11/18, 18:12

Commit message

The possible requests done in jsfunc.inline.js are now stored in a map
that holds the method (e.g. "create") and points to a specific route for
AJAX requests.
Additionally, the inline object is made public for the time being and
explicitly marked as internal.

This allows overriding specific routes, which is required for the
upcoming "Sites" module.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 03/11/18, 17:55

  2. TYPO3com voted on patch set 1 V +1 03/11/18, 18:04 Completed build in 08m 49s on Sun, 11 Mar, 07:04 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20808

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 03/11/18, 18:05

  4. Markus Klein voted on patch set 1 V +2 CR +2 03/11/18, 18:12

  5. Markus Klein merged patch set 2 03/11/18, 18:12