Review main Merged

56100[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 03/11/18, 20:28

Commit message

With refactoring in #79159 one method has accidently been set
public while it is obvious it should be protected. Fix that. Patch
is not considered to be breaking since the method is an internal
method of that abstract class.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • Mona Muzaffar +1
  • Verified V +2
    • Christian Kuhn +2
    • Björn Jacob +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 03/11/18, 19:45

  2. Björn Jacob updated the commit message in patch set 2 03/11/18, 19:52

  3. TYPO3com voted on patch set 1 V -1 03/11/18, 19:54 Completed build in 08m 53s on Sun, 11 Mar, 08:54 PM Test Summary: 1 of 30989 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20811

  4. TYPO3com voted on patch set 2 V +1 03/11/18, 20:01 Completed build in 08m 50s on Sun, 11 Mar, 09:01 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20812

  5. Mona Muzaffar voted on patch set 2 V +1 CR +1 03/11/18, 20:11

  6. Björn Jacob voted on patch set 2 V +1 CR +1 03/11/18, 20:12

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 03/11/18, 20:28

  8. Christian Kuhn merged patch set 3 03/11/18, 20:28

  9. Christian Kuhn commented on patch set 3 03/11/18, 20:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 527da38eefb85b1c0062dc0c916d8e517a01e0b8