Review main Merged

56103[BUGFIX] Correct automatic grid column calculation for forms

Benjamin Kott CR +2 V +2 Easy +2 −2 updated 03/12/18, 19:53

Commit message

The calculation now only includes direct children of the
row elements to produce a meaningful division
of the available space. If the available space is already
consumed by elements the next auto calculated
elements will now consume the space of a full row.

Review

  • Code review CR +2
    • Susi Moog +2
    • Oliver Hader +1
  • Verified V +2
    • Susi Moog +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Benjamin Kott uploaded patch set 1 03/12/18, 09:24

  2. TYPO3com voted on patch set 1 V +1 03/12/18, 09:34 Completed build in 10m 12s on Mon, 12 Mar, 10:34 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20822

  3. Ralf Zimmermann uploaded patch set 2 03/12/18, 09:48

  4. TYPO3com voted on patch set 2 V +1 03/12/18, 09:57 Completed build in 09m 01s on Mon, 12 Mar, 10:57 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20824

  5. Benjamin Kott commented on patch set 2 CR -1 03/12/18, 10:05

    GridColumnClassAutoConfigurationViewHelper.php:113

    should be $gridSize instead of hardcoded 12
  6. Benjamin Kott commented on patch set 3 03/12/18, 10:07

    Published edit on patch set 2.
  7. TYPO3com voted on patch set 3 V +1 03/12/18, 10:15 Completed build in 08m 09s on Mon, 12 Mar, 11:15 AM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20825

  8. Susi Moog updated the commit message in patch set 4 03/12/18, 13:10

  9. TYPO3com voted on patch set 4 V +1 03/12/18, 13:19 Completed build in 08m 58s on Mon, 12 Mar, 02:19 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20839

  10. Susi Moog commented on patch set 4 V +1 CR +1 03/12/18, 13:21

    used for testing (one auto column, one fixed grid, nested) - type: GridRow identifier: gridrow-1 label: 'Grid: Row' renderables: - defaultValue: '' type: Text identifier: text-1 label: Text - type: GridRow identifier: gridrow-2 label: 'Grid: Row' properties: gridColumnClassAutoConfiguration: viewPorts: lg: numbersOfColumnsToUse: '4' renderables: - defaultValue: '' type: Text identifier: text-2 label: Text - defaultValue: '' type: Text identifier: text-3 label: Text
  11. Oliver Hader commented on patch set 4 03/12/18, 16:03

    How to test?
  12. Susi Moog commented on patch set 4 03/12/18, 16:17

    > Patch Set 4: > > How to test? see my test config in the comment above, or: Create a form definition, add a grid row, add child elements, add another grid row as a child with further child elements. (so you have children and grandchildren). Go to the frontend (ideally with bootstrap then it's easiest to see) and note how the elements are distributed.
  13. Oliver Hader voted on patch set 4 V +1 03/12/18, 16:46

  14. Oliver Hader voted on patch set 4 CR +1 03/12/18, 17:00

  15. Susi Moog voted on patch set 4 V +2 CR +2 03/12/18, 19:53

  16. Susi Moog merged patch set 5 03/12/18, 19:53

  17. Susi Moog commented on patch set 5 03/12/18, 19:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 2541f14e1b49b0d0fbec61848cbdbe0c74d22fef