Review TYPO3_7-6 Merged

56104[BUGFIX] Simulate submit button for rsaauth form submit

Andreas Kienast CR +2 V +2 Easy +19 −12 updated 03/22/18, 11:34

Commit message

This patch adds the name and value of the first submit button found in a
form to the input field used to send the form.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
  • Verified V +2
    • Andreas Kienast +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1823

  1. Andreas Kienast uploaded patch set 1 03/12/18, 09:45

  2. Markus Klein commented on patch set 1 CR -1 03/12/18, 09:50

    will do a review. -1 meanwhile
  3. TYPO3com voted on patch set 1 V +1 03/12/18, 09:54 Completed build in 08m 17s on Mon, 12 Mar, 10:54 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1394

  4. Stefan Neufeind uploaded patch set 2 03/12/18, 10:01

  5. Stefan Neufeind commented on patch set 2 03/12/18, 10:01

    WIP because I'm currently trying to re-create the minimized lib-version for it
  6. TYPO3com voted on patch set 2 V +1 03/12/18, 10:08 Completed build in 07m 26s on Mon, 12 Mar, 11:08 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1395

  7. Stefan Neufeind uploaded patch set 3 03/12/18, 10:21

  8. Stefan Neufeind commented on patch set 3 03/12/18, 10:22

    sorry, we both did the port. I've now restored the version from your patchset 1. How did you build the minified version?
  9. Stefan Neufeind commented on patch set 3 V +1 03/12/18, 10:26

    seems to work for me imho
  10. TYPO3com voted on patch set 3 V +1 03/12/18, 10:28 Completed build in 07m 24s on Mon, 12 Mar, 11:28 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1396

  11. Markus Klein commented on patch set 3 CR +1 03/12/18, 10:47

    The minified diff looks good too.
  12. Stefan Neufeind voted on patch set 3 CR +1 03/12/18, 10:52

  13. Markus Klein commented on patch set 3 CR -1 03/12/18, 11:58

    will try to rebuild the minified version again
  14. Markus Klein uploaded patch set 4 03/12/18, 12:13

  15. Stefan Neufeind voted on patch set 4 V +1 CR +1 03/12/18, 12:14

  16. Markus Klein updated the commit message in patch set 5 03/12/18, 12:17

  17. Stefan Neufeind voted on patch set 5 V +1 CR +1 03/12/18, 12:19

  18. TYPO3com voted on patch set 4 V +1 03/12/18, 12:23 Completed build in 09m 33s on Mon, 12 Mar, 01:23 PM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1397

  19. TYPO3com voted on patch set 5 V +1 03/12/18, 12:29 Completed build in 12m 13s on Mon, 12 Mar, 01:29 PM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1398

  20. Andreas Kienast voted on patch set 5 CR +1 03/12/18, 14:51

  21. Andreas Kienast voted on patch set 5 V +2 CR +2 03/13/18, 09:04

  22. Andreas Kienast merged patch set 6 03/13/18, 09:04

  23. Markus Klein commented on patch set 6 03/22/18, 11:34

    Patch has been reverted with https://review.typo3.org/56395