56104[BUGFIX] Simulate submit button for rsaauth form submit
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Stefan Neufeind +1
-
Verified V +2
- Andreas Kienast +2
- Stefan Neufeind +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1823
-
Andreas Kienast uploaded patch set 1 03/12/18, 09:45
-
Markus Klein commented on patch set 1 CR -1 03/12/18, 09:50
will do a review. -1 meanwhile -
TYPO3com voted on patch set 1 V +1 03/12/18, 09:54 Completed build in 08m 17s on Mon, 12 Mar, 10:54 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1394
-
Stefan Neufeind uploaded patch set 2 03/12/18, 10:01
-
Stefan Neufeind commented on patch set 2 03/12/18, 10:01
WIP because I'm currently trying to re-create the minimized lib-version for it -
TYPO3com voted on patch set 2 V +1 03/12/18, 10:08 Completed build in 07m 26s on Mon, 12 Mar, 11:08 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1395
-
Stefan Neufeind uploaded patch set 3 03/12/18, 10:21
-
Stefan Neufeind commented on patch set 3 03/12/18, 10:22
sorry, we both did the port. I've now restored the version from your patchset 1. How did you build the minified version? -
Stefan Neufeind commented on patch set 3 V +1 03/12/18, 10:26
seems to work for me imho -
TYPO3com voted on patch set 3 V +1 03/12/18, 10:28 Completed build in 07m 24s on Mon, 12 Mar, 11:28 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1396
-
Markus Klein commented on patch set 3 CR +1 03/12/18, 10:47
The minified diff looks good too. -
Stefan Neufeind voted on patch set 3 CR +1 03/12/18, 10:52
-
Markus Klein commented on patch set 3 CR -1 03/12/18, 11:58
will try to rebuild the minified version again -
Markus Klein uploaded patch set 4 03/12/18, 12:13
-
Stefan Neufeind voted on patch set 4 V +1 CR +1 03/12/18, 12:14
-
Markus Klein updated the commit message in patch set 5 03/12/18, 12:17
-
Stefan Neufeind voted on patch set 5 V +1 CR +1 03/12/18, 12:19
-
TYPO3com voted on patch set 4 V +1 03/12/18, 12:23 Completed build in 09m 33s on Mon, 12 Mar, 01:23 PM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1397
-
TYPO3com voted on patch set 5 V +1 03/12/18, 12:29 Completed build in 12m 13s on Mon, 12 Mar, 01:29 PM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1398
-
Andreas Kienast voted on patch set 5 CR +1 03/12/18, 14:51
-
Andreas Kienast voted on patch set 5 V +2 CR +2 03/13/18, 09:04
-
Andreas Kienast merged patch set 6 03/13/18, 09:04
-
Markus Klein commented on patch set 6 03/22/18, 11:34
Patch has been reverted with https://review.typo3.org/56395