56114[BUGFIX] Prevent duplicating icons definition in the SVG tree
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 910
-
Oliver Hader uploaded patch set 1 03/12/18, 15:39
-
TYPO3com voted on patch set 1 V +1 03/12/18, 15:50 Completed build in 10m 34s on Mon, 12 Mar, 04:50 PM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2082
-
Susi Moog commented on patch set 1 V -1 03/12/18, 22:05
My category tree does not have any icons anymore in 8.7 after applying the patch. -
Christian Kuhn commented on patch set 1 CR -1 03/12/18, 22:05
missing icons in svg tree, see v8 styleguide after browser cache clear. -
Oliver Hader commented on patch set 1 V -1 03/12/18, 22:06
I did not test that one... Tymek wanted to have a look as well... -
Oliver Hader wrote 03/12/18, 22:06
Assignee added: Tymoteusz Motylewski <t.motylewski@gmail.com> -
Oliver Hader commented on patch set 1 03/12/18, 22:07
Besides that, I'm not sure whether a back-port is required here at all... -
Tymoteusz Motylewski commented on patch set 1 03/13/18, 09:50
the backport is required, however in v8 there is no visual bug, so users are not affected AFAIK. Without the patch on every tree refresh the icon definitions (inside <defs> tag) are being duplicated. So we can postpone merge of this patch after todays release. I still need to test it in v8. -
Tymoteusz Motylewski commented on patch set 1 CR -2 03/15/18, 13:13
a backport would require backporting some other refactoring (the structure of data.icons has chanegd between 8 and 9). I'm abandoning the change. the backport will not happen. -
Tymoteusz Motylewski abandoned the change 03/15/18, 13:13