Review TYPO3_8-7 Abandoned

56114[BUGFIX] Prevent duplicating icons definition in the SVG tree

Oliver Hader CR 0 V 0 Easy +3 −0 updated 03/15/18, 13:13

Commit message

Prevent duplicating icons definition in the SVG tree.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 910

  1. Oliver Hader uploaded patch set 1 03/12/18, 15:39

  2. TYPO3com voted on patch set 1 V +1 03/12/18, 15:50 Completed build in 10m 34s on Mon, 12 Mar, 04:50 PM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2082

  3. Susi Moog commented on patch set 1 V -1 03/12/18, 22:05

    My category tree does not have any icons anymore in 8.7 after applying the patch.
  4. Christian Kuhn commented on patch set 1 CR -1 03/12/18, 22:05

    missing icons in svg tree, see v8 styleguide after browser cache clear.
  5. Oliver Hader commented on patch set 1 V -1 03/12/18, 22:06

    I did not test that one... Tymek wanted to have a look as well...
  6. Oliver Hader wrote 03/12/18, 22:06

    Assignee added: Tymoteusz Motylewski <t.motylewski@gmail.com>
  7. Oliver Hader commented on patch set 1 03/12/18, 22:07

    Besides that, I'm not sure whether a back-port is required here at all...
  8. Tymoteusz Motylewski commented on patch set 1 03/13/18, 09:50

    the backport is required, however in v8 there is no visual bug, so users are not affected AFAIK. Without the patch on every tree refresh the icon definitions (inside <defs> tag) are being duplicated. So we can postpone merge of this patch after todays release. I still need to test it in v8.
  9. Tymoteusz Motylewski commented on patch set 1 CR -2 03/15/18, 13:13

    a backport would require backporting some other refactoring (the structure of data.icons has chanegd between 8 and 9). I'm abandoning the change. the backport will not happen.
  10. Tymoteusz Motylewski abandoned the change 03/15/18, 13:13