Review TYPO3_8-7 Merged

56117[BUGFIX] Correct automatic grid column calculation for forms

Susi Moog CR +2 V +2 Easy +2 −2 updated 03/12/18, 21:35

Commit message

The calculation now only includes direct children of the
row elements to produce a meaningful division
of the available space. If the available space is already
consumed by elements the next auto calculated
elements will now consume the space of a full row.

Review

  • Code review CR +2
    • Susi Moog +2
  • Verified V +2
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Susi Moog commented on patch set 1 03/12/18, 19:53

    Cherry Picked from branch master.
  2. Susi Moog updated the commit message in patch set 2 03/12/18, 19:53

  3. TYPO3com voted on patch set 1 V +1 03/12/18, 20:05 Completed build in 11m 18s on Mon, 12 Mar, 09:05 PM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2084

  4. TYPO3com voted on patch set 2 V +1 03/12/18, 20:08 Completed build in 14m 56s on Mon, 12 Mar, 09:08 PM Test Summary: 58161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2085

  5. Susi Moog voted on patch set 2 V +2 CR +2 03/12/18, 21:35

  6. Susi Moog merged patch set 3 03/12/18, 21:35