Review TYPO3_8-7 Merged

56126[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again

Oliver Hader CR +2 V +2 Hard +498 −2 updated 03/13/18, 10:17

Commit message

Issue #77589 introduced automatic resolving of relative paths during
v8.4.0 development in the PageRenderer component. Doing this in some
backend context is fine - however if applied for frontend rendering,
config.absRefPrefix was not applied anymore to these files.

Reason for this behavior is applying PathUtility::getAbsoluteWebPath
which prefixes files with /<TYPO3_SITE_PATH>/ - however absRefPrefix
only works on relative URIs. Extending the absRefPrefix patterns in
TypoScriptFrontendController::setAbsRefPrefix() by mentioned prefix
would adjust explicitly defined absolute paths as well.

To solve this bug, the prefix /<TYPO3_SITE_PATH>/ is
not applied in frontend rendering contexts anymore.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Stefan Neufeind +1
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 56

  1. Oliver Hader commented on patch set 1 03/13/18, 09:08

    Cherry Picked from branch master.
  2. Stefan Neufeind voted on patch set 1 CR +1 03/13/18, 09:11

  3. TYPO3com voted on patch set 1 V +1 03/13/18, 09:18 Completed build in 09m 38s on Tue, 13 Mar, 10:18 AM Test Summary: 58195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2092

  4. Susi Moog voted on patch set 1 V +1 CR +1 03/13/18, 09:59

  5. Oliver Hader voted on patch set 1 V +2 CR +2 03/13/18, 10:17

  6. Oliver Hader merged patch set 2 03/13/18, 10:17