Review main Merged

56128[TASK] Update composer-dep nikic/php-parser to 4.0.1

Stefan Neufeind CR +2 V +2 Normal +61 −57 updated 05/10/18, 18:18

Commit message

Command used:
composer require nikic/php-parser ^4.0

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 1623

  1. Stefan Neufeind uploaded patch set 1 03/13/18, 10:34

  2. TYPO3com voted on patch set 1 V -1 03/13/18, 10:47 Completed build in 12m 41s on Tue, 13 Mar, 11:47 AM Test Summary: 144 of 31023 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20897

  3. Andreas Wolf rebased onto patch set 2 03/16/18, 17:16

  4. TYPO3com voted on patch set 2 V -1 03/16/18, 17:29 Completed build in 13m 43s on Fri, 16 Mar, 06:29 PM Test Summary: 144 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21297

  5. Anja Leichsenring uploaded patch set 3 03/19/18, 20:11

  6. TYPO3com voted on patch set 3 V -1 03/19/18, 20:22 Completed build in 10m 43s on Mon, 19 Mar, 09:22 PM Test Summary: 144 of 31034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21702

  7. Anja Leichsenring commented on patch set 3 V -1 03/19/18, 20:32

    the update breaks all unit tests, indicating a change of behavior in the major update. Investigation on needed changes is necessary.
  8. Anja Leichsenring commented on patch set 3 03/19/18, 20:40

    I put the different outputs into the ticket for further reference.
  9. Stefan Neufeind uploaded patch set 4 03/20/18, 08:12

  10. Stefan Neufeind commented on patch set 4 03/20/18, 08:14

    Almost there imho. Could somebody else take a fresh look please?
  11. TYPO3com voted on patch set 4 V -1 03/20/18, 08:22 Completed build in 10m 06s on Tue, 20 Mar, 09:22 AM Test Summary: 24 of 31034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21710

  12. Christian Kuhn uploaded patch set 5 05/09/18, 16:30

  13. Christian Kuhn commented on patch set 5 05/09/18, 16:30

    rebased for now.
  14. TYPO3com voted on patch set 5 V -1 05/09/18, 16:39 Completed build in 08m 52s on Wed, 9 May, 06:39 PM Test Summary: 24 of 31250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23249

  15. Christian Kuhn commented on patch set 5 CR -1 05/10/18, 13:54

    on it.
  16. Christian Kuhn uploaded patch set 6 05/10/18, 14:08

  17. TYPO3com voted on patch set 6 V -1 05/10/18, 14:15 Completed build in 07m 49s on Thu, 10 May, 04:15 PM Test Summary: 21 of 31250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23268

  18. Christian Kuhn uploaded patch set 7 05/10/18, 14:35

  19. TYPO3com voted on patch set 7 V +1 05/10/18, 14:44 Completed build in 08m 58s on Thu, 10 May, 04:44 PM Test Summary: 31003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23270

  20. Anja Leichsenring voted on patch set 7 V +1 CR +1 05/10/18, 14:47

  21. Christian Kuhn voted on patch set 7 V +2 CR +2 05/10/18, 14:47

  22. Christian Kuhn merged patch set 8 05/10/18, 14:47

  23. Stefan Neufeind voted on patch set 8 V +1 CR +1 05/10/18, 18:18