Review main Merged

56130[TASK] Streamline/Fix backend labels by removing superfluous colons

Josef Glatz CR +2 V +2 Hard +496 −493 updated 03/14/18, 13:53

Commit message

Column labels across common tables have many mixed labels
with/without colons. Many longer existing labels still have colons.

Streamlining the backend makes the appearance more uniform.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 50

Show 30 more files

Review log 1420

  1. Josef Glatz uploaded patch set 1 03/13/18, 11:10

  2. TYPO3com voted on patch set 1 V +1 03/13/18, 11:18 Completed build in 07m 56s on Tue, 13 Mar, 12:18 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20901

  3. Josef Glatz voted on patch set 1 CR -1 03/13/18, 13:43

  4. Josef Glatz commented on patch set 1 03/13/18, 13:43

    on it
  5. Georg Ringer commented on patch set 1 03/13/18, 14:57

    locallang_ttc.xlf:451

    why not this?

    locallang.xlf:61 Unresolved

    missing? also below
  6. Josef Glatz uploaded patch set 2 03/13/18, 15:16

  7. Josef Glatz commented on patch set 1 03/13/18, 15:19

    locallang_ttc.xlf:451 Reply Unresolved

    Because of https://forge.typo3.org/issues/84241#Example-1-which-is-a-candidate-for-deletion-in-an-upcoming-patch- ;-) As mentioned in the commit message and issue: I only want to fix actual visible (used) labels in backend by getting most manually as possible. With that I/we can do further research and another patch to find not anymore used labels in the core.
  8. TYPO3com voted on patch set 2 V +1 03/13/18, 15:25 Completed build in 09m 25s on Tue, 13 Mar, 04:25 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20907

  9. Josef Glatz rebased onto patch set 3 03/13/18, 15:34

  10. TYPO3com voted on patch set 3 V +1 03/13/18, 15:43 Completed build in 09m 38s on Tue, 13 Mar, 04:43 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20909

  11. Susi Moog uploaded patch set 4 03/14/18, 13:19

  12. Susi Moog commented on patch set 4 03/14/18, 13:21

    As the patch missed a lot of still used labels (especially in not well-used areas like the info modals, reference display etc.) I opted now to do this via search and replace - if we want to find unused labels, we can probably come up with some script to do so.
  13. TYPO3com voted on patch set 4 V -1 03/14/18, 13:27 Completed build in 08m 42s on Wed, 14 Mar, 02:27 PM Test Summary: 2 of 31025 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20923

  14. Susi Moog uploaded patch set 5 03/14/18, 13:36

  15. Susi Moog uploaded patch set 6 03/14/18, 13:37

  16. TYPO3com voted on patch set 5 V +1 03/14/18, 13:45 Completed build in 09m 08s on Wed, 14 Mar, 02:45 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20925

  17. TYPO3com voted on patch set 6 V +1 03/14/18, 13:47 Completed build in 10m 08s on Wed, 14 Mar, 02:47 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20926

  18. Frank Nägler voted on patch set 6 V +2 CR +2 03/14/18, 13:52

  19. Susi Moog voted on patch set 6 V +1 CR +1 03/14/18, 13:53

  20. Frank Nägler merged patch set 7 03/14/18, 13:53