Review main Merged

56131[TASK] Add missing documentation files and correct errors

Susi Moog CR +2 V +2 Normal +32 −23 updated 03/13/18, 12:27

Commit message

Review

  • Code review CR +2
    • Oliver Hader +2
    • Sascha Rademacher +1
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1214

  1. Susi Moog uploaded patch set 1 03/13/18, 11:33

  2. Oliver Hader voted on patch set 1 CR +1 03/13/18, 11:37

  3. Andreas Kienast voted on patch set 1 CR +1 03/13/18, 11:39

  4. TYPO3com voted on patch set 1 V -1 03/13/18, 11:41 Completed build in 08m 00s on Tue, 13 Mar, 12:41 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20902

  5. Christian Kuhn commented on patch set 1 CR -1 03/13/18, 12:03

    on it.
  6. Christian Kuhn uploaded patch set 2 03/13/18, 12:09

  7. Oliver Hader commented on patch set 2 CR -1 03/13/18, 12:15

    Feature-81654-AddingNovalidateAttributeToFluidFormViewHelper.rst:1

    This moves a 9.0 feature to 8.7.x and thus modifies documentation...
  8. Sascha Rademacher voted on patch set 2 CR +1 03/13/18, 12:15

  9. TYPO3com voted on patch set 2 V +1 03/13/18, 12:18 Completed build in 09m 28s on Tue, 13 Mar, 01:18 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20903

  10. Sascha Rademacher commented on patch set 2 03/13/18, 12:22

    > (1 comment) This is an TYPO3 8.7 Feature: https://forge.typo3.org/issues/81654
  11. Christian Kuhn commented on patch set 2 03/13/18, 12:23

    Feature-81654-AddingNovalidateAttributeToFluidFormViewHelper.rst:1 Reply

    yes. that is correct.
  12. Christian Kuhn commented on patch set 2 03/13/18, 12:25

  13. Oliver Hader commented on patch set 2 V +2 CR +2 03/13/18, 12:27

    This is weird, but I'm merging this for now since it's blocking the current release process
  14. Oliver Hader merged patch set 3 03/13/18, 12:27