56139[BUGFIX] getTreeList must return comma-separated list
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Wouter Wolters +1
- Anja Leichsenring +1
- Alexander Schnitzler +1
-
Verified V +2
- Frans Saris +2
- Anja Leichsenring +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 4760
Show 2635 earlier messages
-
Guido Schmechel uploaded patch set 1 03/13/18, 20:24
-
TYPO3com voted on patch set 1 V +1 03/13/18, 20:33 Completed build in 09m 02s on Tue, 13 Mar, 09:33 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20911
-
Markus Klein commented on patch set 1 03/13/18, 22:30
Please adjust the commit message to comply with our guidelines. See https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/GeneralTopics/CommitMessage.html#summary-line-first-line -
Markus Klein commented on patch set 1 03/13/18, 22:32
This should definitely be covered with tests! -
Guido Schmechel commented on patch set 1 03/14/18, 07:25
I will try it with tests. I had seen that there were no tests for it so far. I will definitely need support for it ;-) Thanks for your feedback. -
Guido Schmechel uploaded patch set 2 03/16/18, 16:36
-
TYPO3com voted on patch set 2 V -1 03/16/18, 16:36 Completed build in 11s on Fri, 16 Mar, 05:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21273
-
Guido Schmechel uploaded patch set 3 03/16/18, 16:38
-
TYPO3com voted on patch set 3 V -1 03/16/18, 16:38 Completed build in 11s on Fri, 16 Mar, 05:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21275
-
Guido Schmechel uploaded patch set 4 03/16/18, 16:48
-
TYPO3com voted on patch set 4 V -1 03/16/18, 17:03 Completed build in 14m 56s on Fri, 16 Mar, 06:03 PM Test Summary: 3 of 31031 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21282
-
Guido Schmechel uploaded patch set 5 03/16/18, 17:07
-
Guido Schmechel commented on patch set 5 03/16/18, 17:07
Retrigger bamboo -
Guido Schmechel wrote 03/16/18, 17:07
Removed reviewer Markus Klein. -
TYPO3com voted on patch set 5 V +1 03/16/18, 17:22 Completed build in 14m 46s on Fri, 16 Mar, 06:22 PM Test Summary: 30879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21293
-
Markus Klein commented on patch set 5 03/16/18, 21:30
Thanks for adding the tests here. I see you massively had to mock away the DB stuff here. That was for sure a lot of work. Maybe it makes sense to also add functional tests, where we have the DB at hand and can test that end-to-end? -
Christian Kuhn commented on patch set 5 03/16/18, 22:00
It seems Guido really put a lot of energy into that patch. after asking for test coverage he now came up with an exhausting unit test on this. I like that. Markus, do you think you could step in with a functional test to help here a bit, if you want that additional coverage? -
Markus Klein commented on patch set 5 CR +1 03/17/18, 00:57
Yes I can, but I want to make it a positive experience for Guido and therefore I propose to merge that one and I will add those tests with an extra patch. And yes, very good work Guido! -
Guido Schmechel commented on patch set 5 03/17/18, 08:55
Thanks for your warm words :-) Inn my eyes there are two problems here: - Duplicate code for the db pages stuff. I had an extra function for this, but i should hand over all seven prophecies. Do you think an array as param in an extra function is okay? - In $statementProphecy->fetch()->willReturn there are fix 4 params. This is not the best flexible way if i add another dataProvider ;-) Maybe you have some hints? Yeah the test is green, but it could be a little bit better ;-) -
Guido Schmechel uploaded patch set 6 03/18/18, 15:11
-
TYPO3com voted on patch set 6 V +1 03/18/18, 15:20 Completed build in 09m 27s on Sun, 18 Mar, 04:20 PM Test Summary: 30903 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21662
-
Guido Schmechel commented on patch set 6 03/18/18, 15:23
So. Now i have supplemented my suggestion with the extra function. It is in my view more readable. And that would be my last suggestion for now. Sorry ;-) -
Tobi Kretschmann voted on patch set 6 CR +1 03/19/18, 09:38
-
Mathias Schreiber voted on patch set 6 V +1 CR +1 03/22/18, 08:47
-
Stefan Neufeind commented on patch set 6 03/30/18, 12:46
should say what this fixes, not that it's wrong (was wrong before the patch) -
Guido Schmechel updated the commit message in patch set 7 03/30/18, 14:43
-
TYPO3com voted on patch set 7 V +1 03/30/18, 14:51 Completed build in 07m 51s on Fri, 30 Mar, 04:51 PM Test Summary: 30951 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21880
-
Oliver Klee updated the commit message in patch set 8 03/30/18, 14:55
-
TYPO3com voted on patch set 8 V +1 03/30/18, 15:02 Completed build in 07m 36s on Fri, 30 Mar, 05:02 PM Test Summary: 30951 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21881
-
Markus Klein commented on patch set 8 04/05/18, 08:25
QueryGenerator.php:1590can $theSubList ever be 0? If so then empty() is the wrong check here, we should !== '' -
Guido Schmechel uploaded patch set 9 04/05/18, 18:40
-
Guido Schmechel commented on patch set 9 04/05/18, 18:42
> Patch Set 8: > > (1 comment) I added a test with rootpage 0 and without subpages, but he go never in this case. Only a direct return of 0 as int is possible. So this condition is fine. Thanks for your input -
TYPO3com voted on patch set 9 V +1 04/05/18, 18:49 Completed build in 08m 19s on Thu, 5 Apr, 08:49 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22063
-
Markus Klein voted on patch set 9 CR +1 04/06/18, 19:53
-
Frank Nägler commented on patch set 9 05/09/18, 11:41
@Guido: can you rebase the patch?
-
Massimiliano Fani voted on patch set 9 CR +1 05/11/18, 14:15
-
Markus Klein commented on patch set 9 CR 0 05/11/18, 22:11
rebase needed -
Markus Klein uploaded patch set 10 05/11/18, 22:12
-
Markus Klein voted on patch set 10 CR +1 05/11/18, 22:13
-
TYPO3com voted on patch set 10 V -1 05/11/18, 22:22 Completed build in 09m 28s on Sat, 12 May, 12:22 AM Test Summary: 542 of 31370 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23339
-
TYPO3com commented on patch set 10 05/12/18, 10:40 Completed build in 12h 36m 28s on Sat, 12 May, 12:40 PM Test Summary: 1456 of 31370 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23339
-
TYPO3com commented on patch set 10 05/12/18, 14:06 Completed build in 4h 30m 02s on Sat, 12 May, 04:06 PM Test Summary: 306 of 31370 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23339
-
Alexander Schnitzler commented on patch set 10 CR -1 05/14/18, 09:19
QueryGenerator.php:1588I am sorry but I dislike this whole new approach a lot due to a lot of string analysing and string modification because we don't have a method with a single purpose here. All these if statements are hard to test, especially in a recursion, so I'd recommend splitting the logic of fetching a tree as (multidimensional) array and making it a flat list into several different methods. What about one method "getTree", one "flattenTree" and this "getTreeList" with all the these having a single purpose and a better testability? -
Tymoteusz Motylewski commented on patch set 10 05/14/18, 17:14
I agree with Alex that it would be nicer to refactor this code, however then a backport to stable branches would not be possible. What about fixing it this way here and refactor in a separate change? -
Alexander Schnitzler commented on patch set 10 05/14/18, 17:28
Why isn't it possible to refactor the code while keeping the api intact? The mentioned new methods don't need to be public in the first place. If we start with just the test, then go on with the refactoring I don't see why it can't go into older versions as bugfix. -
Tymoteusz Motylewski commented on patch set 10 05/15/18, 08:12
Well, if it's possible to do refactoring with keeping the API then it sounds much better. However the bigger the change is the risk of breaking something is higher and it's less probable it would be accepted to 7.6 branch which is in priority bugfixing mode. -
Alexander Schnitzler commented on patch set 10 05/15/18, 16:28
The bad thing here is that we don't have an existing test and on top of that this patch introduces an awkward unit test for testing a quite complex function. While I am trying to reduce all these unit tests that need dozens of mocks and expectations in Extbase, I don't like introducing new ones in this area. I am pretty sure, that I will have some spare time tomorrow. If so, I will start with some functional tests, so we have a proper base for this bugfix. -
Guido Schmechel commented on patch set 10 05/15/18, 17:25
Functional tests were planned with a separate patch, see comments from 16.03. I put in quite a bit of energy here, but ultimately it's only important to me that the bug can be fixed from 7.6 :-) -
Alexander Schnitzler commented on patch set 10 05/16/18, 09:00
Hi Guido, I see that you want to get this in as fast as possible and it's up to others to overrule my -1 here. I still think, that we neither have a good test nor a good patch here. That doesn't mean I don't honor your work and your effort. I can imagine how much time you put into the test, I did write a lot of complex unit tests myself back then. The issue with these complex tests are, that they only do good once, the moment you want to get the patch in the first time. Later, during a refactoring, these tests are a pain in the ass because they test which components do what exactly rather then testing the outcome. -
Alexander Schnitzler commented on patch set 10 05/16/18, 11:15
I created a set of functional tests here: https://review.typo3.org/#/c/56974/ It also includes tests for the cases mentioned in the ticket. -
Alexander Schnitzler uploaded patch set 11 05/16/18, 17:04
-
TYPO3com voted on patch set 11 V +1 05/16/18, 17:11 Completed build in 07m 00s on Wed, 16 May, 07:11 PM Test Summary: 31187 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23569
-
Alexander Schnitzler voted on patch set 11 V +1 CR +1 05/16/18, 17:12
-
Anja Leichsenring commented on patch set 11 05/16/18, 17:36
wouldn't the tests work now after the fix? -
Wouter Wolters voted on patch set 11 CR +1 05/16/18, 17:54
-
Anja Leichsenring commented on patch set 11 V +1 CR +1 05/16/18, 18:08
colorblind I am ... -
Frans Saris voted on patch set 11 V +2 CR +2 05/16/18, 18:50
-
Frans Saris merged patch set 12 05/16/18, 18:50
-
Frans Saris commented on patch set 12 05/16/18, 18:56
Can't find Tests/Functional/Database/QueryGeneratorTest.php in the 8.7 branch. Drop the test or introduce this class there with this change? -
Christian Kuhn commented on patch set 12 05/17/18, 08:12
the tests have been added by alex with https://review.typo3.org/#/c/56974/ beforehand. i guess if you copy the file to v8, test may work without issues, more risk with v7, though. if it gives any troubly, i'd just omit the tests in v8 & v7, shouldn't give headaches.