Review main Merged

56142[BUGFIX] Trigger submit of RSA encrypted form properly

Andreas Kienast CR -1 V +2 Easy +2 −2 updated 03/21/18, 10:20

Commit message

The change of #76120 changed the selector of possible submit buttons.
However, in Firefox a submit is not triggered when a focussed submit
element is clicked via JavaScript.

The code is changed to enforce a submit of the form instead.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Review

  • Code review CR -1
    • Andreas Wolf +2
    • Markus Klein +1
    • Jigal van Hemert +1
    • Susi Moog -1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 1617

  1. Andreas Kienast uploaded patch set 1 03/14/18, 08:30

  2. TYPO3com voted on patch set 1 V +1 03/14/18, 08:40 Completed build in 10m 15s on Wed, 14 Mar, 09:40 AM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20916

  3. Markus Klein commented on patch set 1 CR +1 03/14/18, 10:00

    not tested yet, but reading looks good
  4. Susi Moog commented on patch set 1 V +1 CR +1 03/14/18, 10:47

    Thanks Markus for the testing instructions :)
  5. Susi Moog commented on patch set 1 03/14/18, 11:08

    ... tested with firefox, chrome, edge, IE 11
  6. Jigal van Hemert commented on patch set 1 V +1 CR +1 03/14/18, 14:08

    Tested with FF, Chrome, IE11 on 8.7
  7. Simon Gilli commented on patch set 1 03/14/18, 14:12

    > Tested with FF, Chrome, IE11 on 8.7 Is that the preferred way to commit a test for one version only? I added my +1 directly to the 8.7 patch. Was that wrong?
  8. Jigal van Hemert commented on patch set 1 03/14/18, 15:01

    > > Tested with FF, Chrome, IE11 on 8.7 > > Is that the preferred way to commit a test for one version only? I > added my +1 directly to the 8.7 patch. Was that wrong? No, but the code was identical for both versions and I quickly tested it in an 8.7 installation I was working on. Will test with master later if it hasn't been merged yet.
  9. Susi Moog commented on patch set 1 V 0 CR -1 03/14/18, 15:15

    I'm blocking submit for a bit to give us time to analyze whether this reverts the original bugfix that triggered this error.
  10. Stefan Neufeind commented on patch set 1 V +1 03/15/18, 11:14

    I couldn't reproduce this issue with FF59 on master for some reason. But on the 8.7-branch the 8.7-version of the patch worked for me.
  11. Andreas Wolf commented on patch set 1 V +1 CR +1 03/16/18, 11:04

    I could reproduce it on FF 58 and the patch fixes the issue for me. I accidentally merged the 8.7 patch already; I think this one should also be merged, but I'd await feedback from Susi on that one for now.
  12. Andreas Wolf voted on patch set 1 V +2 CR +2 03/16/18, 12:04

  13. Andreas Wolf merged patch set 2 03/16/18, 12:04

  14. Susi Moog commented on patch set 2 03/16/18, 12:06

    > Patch Set 1: Verified+1 Code-Review+1 > > I could reproduce it on FF 58 and the patch fixes the issue for me. I accidentally merged the 8.7 patch already; I think this one should also be merged, but I'd await feedback from Susi on that one for now. well, no point in having differences between master and 8.7 if we can help it, so go ahead and merge (and sorry, was out at the doctor's office, so needed some time to reply.)
  15. Oliver Hader wrote 03/21/18, 09:30

    Created a revert of this change as I2c676b038a10abd8d2c7fb330968657e8fbb81d3
  16. Oliver Hader commented on patch set 2 03/21/18, 09:49

    > uglify-js/bin/uglifyjs \ RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js Okay, none of the mentioned source files have been modified and still we get an updated minified version... why?

    RsaEncryptionWithLib.min.js:1

    Where is this change coming from? It is not related to the changes in the source files...
  17. Oliver Hader commented on patch set 2 03/21/18, 10:20

    Okay, I see now... the previous uglified version was build with an outdated build chain - so that basically was a "side-fix"