Review TYPO3_8-7 Merged

56143[BUGFIX] Trigger submit of RSA encrypted form properly

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 03/21/18, 09:30

Commit message

The change of #76120 changed the selector of possible submit buttons.
However, in Firefox a submit is not triggered when a focussed submit
element is clicked via JavaScript.

The code is changed to enforce a submit of the form instead.

RsaEncryptionWithLib.min.js created with:
../../../../../../Build/node_modules/uglify-js/bin/uglifyjs \
RsaLibrary.js RsaEncryption.js > RsaEncryptionWithLib.min.js

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Kevin Ditscheid +1
  • Verified V +2
    • Andreas Wolf +2
    • Simon Gilli +1
    • Kevin Ditscheid +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 03/14/18, 08:31

  2. TYPO3com voted on patch set 1 V +1 03/14/18, 08:41 Completed build in 10m 11s on Wed, 14 Mar, 09:41 AM Test Summary: 58195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2101

  3. Simon Gilli commented on patch set 1 V +1 03/14/18, 10:09

    Tested with lastest versions of Firefox and Chrome
  4. Kevin Ditscheid commented on patch set 1 V +1 CR +1 03/14/18, 17:45

    Works for me on Firefox 58.0.2
  5. Andreas Wolf voted on patch set 1 V +2 CR +2 03/16/18, 11:00

  6. Andreas Wolf merged patch set 2 03/16/18, 11:00

  7. Oliver Hader wrote 03/21/18, 09:30

    Created a revert of this change as Ie1e8ced2eba3663b6da1248ccc0a3377217d5dd4