Review TYPO3_7-6 Abandoned

56144[BUGFIX] Trigger submit of RSA encrypted form properly

Andreas Kienast CR 0 V 0 Easy +1 −1 updated 03/21/18, 09:29

Commit message

The change of #76120 changed the selector of possible submit buttons.
However, in Firefox a submit is not triggered when a focussed submit
element is clicked via JavaScript.

The code is changed to enforce a submit of the form instead.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 68

  1. Andreas Kienast uploaded patch set 1 03/14/18, 08:36

  2. Andreas Kienast uploaded patch set 2 03/14/18, 08:44

  3. TYPO3com voted on patch set 1 V +1 03/14/18, 08:44 Completed build in 07m 45s on Wed, 14 Mar, 09:44 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1407

  4. TYPO3com voted on patch set 2 V +1 03/14/18, 08:51 Completed build in 07m 25s on Wed, 14 Mar, 09:51 AM Test Summary: 49129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1408

  5. Stephan Großberndt voted on patch set 2 V +1 03/16/18, 12:30

  6. Jigal van Hemert voted on patch set 2 V +1 CR +1 03/16/18, 14:17

  7. Oliver Hader commented on patch set 2 CR -2 03/21/18, 09:29

    Work-around will be reverted, see master change
  8. Oliver Hader abandoned the change 03/21/18, 09:29