56147[FEATURE] Show value of fields in debug mode
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Susi Moog +1
-
Verified V +2
- Frank Nägler +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php3+27 −0
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php2+1 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxLabeledToggleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxToggleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/RadioElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+2 −2
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-83748-ShowValueOfFieldsInDebugMode.rstnew+24 −0
Review log 2131
Show 46 earlier messages
-
Georg Ringer uploaded patch set 1 03/14/18, 13:58
-
Mathias Brodala commented on patch set 2 03/14/18, 14:00
Published edit on patch set 1. -
TYPO3com voted on patch set 1 V +1 03/14/18, 14:07 Completed build in 08m 58s on Wed, 14 Mar, 03:07 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20928
-
Susi Moog commented on patch set 2 V -1 03/14/18, 14:08
Should also work for the newly styled checkbox elements. -
Wouter Wolters commented on patch set 2 03/14/18, 14:09
AbstractFormElement.php:377really mixed? not even string|int?AbstractFormElement.php:403strict return type? -
TYPO3com voted on patch set 2 V +1 03/14/18, 14:10 Completed build in 09m 45s on Wed, 14 Mar, 03:10 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20929
-
Georg Ringer commented on patch set 2 03/14/18, 14:25
> Patch Set 2: > > (2 comments) value could be an integer and then an int would be returned ... -
Georg Ringer uploaded patch set 3 03/14/18, 14:38
-
TYPO3com voted on patch set 3 V +1 03/14/18, 14:46 Completed build in 08m 32s on Wed, 14 Mar, 03:46 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20931
-
Frank Nägler uploaded patch set 4 03/14/18, 14:48
-
TYPO3com voted on patch set 4 V +1 03/14/18, 14:56 Completed build in 08m 18s on Wed, 14 Mar, 03:56 PM Test Summary: 30871 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20932
-
Frank Nägler uploaded patch set 5 03/14/18, 15:06
-
Frank Nägler voted on patch set 5 V +1 CR +1 03/14/18, 15:07
-
TYPO3com voted on patch set 5 V -1 03/14/18, 15:15 Completed build in 08m 37s on Wed, 14 Mar, 04:15 PM Test Summary: 3 of 31023 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20933
-
Andreas Kienast commented on patch set 5 03/14/18, 15:15
CheckboxElement.php:202Do we need htmlspecialchars here? -
Georg Ringer commented on patch set 5 03/14/18, 15:30
CheckboxElement.php:202Reply Unresolvedon it -
Georg Ringer uploaded patch set 6 03/14/18, 15:31
-
TYPO3com voted on patch set 6 V -1 03/14/18, 15:41 Completed build in 09m 25s on Wed, 14 Mar, 04:41 PM Test Summary: 103 of 31023 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20935
-
Oliver Klee commented on patch set 6 03/14/18, 15:52
AbstractFormElement.php:403Please let's have return type hinting for this method. -
Georg Ringer uploaded patch set 7 03/14/18, 15:56
-
TYPO3com voted on patch set 7 V -1 03/14/18, 16:05 Completed build in 08m 15s on Wed, 14 Mar, 05:05 PM Test Summary: 103 of 31023 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20939
-
Georg Ringer rebased onto patch set 8 03/15/18, 05:50
-
TYPO3com voted on patch set 8 V -1 03/15/18, 05:58 Completed build in 08m 28s on Thu, 15 Mar, 06:58 AM Test Summary: 103 of 31028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20951
-
Susi Moog commented on patch set 8 03/15/18, 10:48
> Patch Set 8: Verified-1 > > Completed build in 08m 28s on Thu, 15 Mar, 06:58 AM > Test Summary: 103 of 31028 failed > Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20951 The test fails are valid by the way and have to be fixed (see for example: https://bamboo.typo3.com/artifact/CORE-GTC/ACMYPHP7201/build-20951/Test-Report/typo3temp/var/tests/AcceptanceReports/record_5aaa09bd6cefc_SearchCest__Search_and_test_if_autocompletion_works/index.html ) -
Georg Ringer uploaded patch set 9 03/15/18, 12:22
-
TYPO3com voted on patch set 9 V -1 03/15/18, 12:37 Completed build in 15m 10s on Thu, 15 Mar, 01:37 PM Test Summary: 3 of 31028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20975
-
Frank Nägler uploaded patch set 10 03/15/18, 19:23
-
TYPO3com voted on patch set 10 V +1 03/15/18, 19:32 Completed build in 08m 48s on Thu, 15 Mar, 08:32 PM Test Summary: 30879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21105
-
Susi Moog voted on patch set 10 V +1 CR +1 03/15/18, 19:57
-
Frank Nägler voted on patch set 10 V +2 CR +2 03/15/18, 19:58
-
Frank Nägler merged patch set 11 03/15/18, 19:58