Review main Merged

56152[BUGFIX] LinkHandler creates wrong TS configuration

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 03/15/18, 13:34

Commit message

DatabaseRecordLinkBuilder creates a wrong
TypoScript configuration because of using
array_merge_recursive which joins all array elements
instead of replacing them.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Pascal Rinker +1
  • Verified V +2
    • Frank Nägler +2
    • Pascal Rinker +1
    • Wolfgang Wagner +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Froemken uploaded patch set 1 03/15/18, 09:10

  2. TYPO3com voted on patch set 1 V +1 03/15/18, 09:19 Completed build in 08m 36s on Thu, 15 Mar, 10:19 AM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20952

  3. Wolfgang Wagner voted on patch set 1 V +1 03/15/18, 09:25

  4. Pascal Rinker voted on patch set 1 V +1 CR +1 03/15/18, 09:32

  5. Frank Nägler voted on patch set 1 V +2 CR +2 03/15/18, 13:34

  6. Frank Nägler merged patch set 2 03/15/18, 13:34

  7. Frank Nägler commented on patch set 2 03/15/18, 13:34

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 3ada8c59dfa546dbfa6477df66d7f67591290140