Review TYPO3_8-7 Merged

56157[BUGFIX] Accept configuration for external plugins from presets in ckeditor

Frank Nägler CR +2 V +2 Easy +3 −0 updated 03/15/18, 11:21

Commit message

Currently the default configuration of an external
plugin is always used for the configuration. This patch takes care
of a proper merging of the configuration.

The configuration of the extension is taken as default. If a
custom configuration in a preset is available, both configurations
will be merged.

Review

  • Code review CR +2
    • Frank Nägler +2
  • Verified V +2
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Frank Nägler commented on patch set 1 03/15/18, 11:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/15/18, 11:16 Completed build in 14m 15s on Thu, 15 Mar, 12:16 PM Test Summary: 58195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2109

  3. Frank Nägler voted on patch set 1 V +2 CR +2 03/15/18, 11:21

  4. Frank Nägler merged patch set 2 03/15/18, 11:21