56180[TASK] Use ServerRequestInterface in ContentElement/NewContentElementController
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+133 −49
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84307-ProtectedMethodsAndPropertiesInNewContentElementController.rstnew+58 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+30 −0
Review log 1524
-
Mathias Brodala uploaded patch set 1 03/15/18, 16:29
-
TYPO3com voted on patch set 1 V +1 03/15/18, 16:38 Completed build in 09m 27s on Thu, 15 Mar, 05:38 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21063
-
Mathias Brodala uploaded patch set 2 03/15/18, 16:38
-
TYPO3com voted on patch set 2 V +1 03/15/18, 16:51 Completed build in 12m 16s on Thu, 15 Mar, 05:51 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21066
-
Mathias Brodala uploaded patch set 3 03/15/18, 17:45
-
TYPO3com voted on patch set 3 V +1 03/15/18, 17:54 Completed build in 09m 23s on Thu, 15 Mar, 06:54 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21086
-
Mathias Brodala uploaded patch set 4 03/15/18, 18:31
-
Mathias Brodala uploaded patch set 5 03/15/18, 18:41
-
TYPO3com voted on patch set 5 V -1 03/15/18, 18:41 Completed build in 07s on Thu, 15 Mar, 07:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21097
-
TYPO3com voted on patch set 4 V +1 03/15/18, 18:41 Completed build in 10m 18s on Thu, 15 Mar, 07:41 PM Test Summary: 30876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21091
-
Mathias Brodala uploaded patch set 6 03/15/18, 19:13
-
TYPO3com voted on patch set 6 V -1 03/15/18, 19:13 Completed build in 07s on Thu, 15 Mar, 08:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21103
-
Mathias Brodala uploaded patch set 7 03/15/18, 19:42
-
TYPO3com voted on patch set 7 V -1 03/15/18, 19:42 Completed build in 11s on Thu, 15 Mar, 08:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21115
-
Mathias Brodala uploaded patch set 8 03/15/18, 19:43
-
TYPO3com voted on patch set 8 V +1 03/15/18, 19:54 Completed build in 11m 02s on Thu, 15 Mar, 08:54 PM Test Summary: 30879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21116
-
Christian Kuhn uploaded patch set 9 03/15/18, 19:55
-
TYPO3com voted on patch set 9 V +1 03/15/18, 20:06 Completed build in 11m 38s on Thu, 15 Mar, 09:06 PM Test Summary: 30879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21123
-
Christian Kuhn voted on patch set 9 V +1 CR +1 03/15/18, 20:13
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 03/15/18, 20:33
-
Christian Kuhn voted on patch set 9 V +2 CR +2 03/15/18, 20:35
-
Christian Kuhn merged patch set 10 03/15/18, 20:35
-
Alexander Opitz commented on patch set 10 11/02/18, 11:56
Breaking API changes? :-( So Post -1 -
Mathias Brodala commented on patch set 10 11/02/18, 12:11
> Breaking API changes? :-( > So Post -1 That's a bit late by now. What changes do you mean exactly?