Review TYPO3_8-7 Merged

56197[BUGFIX] Respect empty allowedMimeTypes for file uploads

Susi Moog CR +2 V +2 Easy +14 −4 updated 05/02/18, 12:35

Commit message

Make it possible to allow all mime types (except php) within file upload
form elements.
Since there are some default mime types configured within the ext:form
standard setup, you have to remove this default mime types within your
form definition (or reconfigure the default values within your custom
ext:form setup).

FileUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null
    3: null

ImageUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Stephan Großberndt +1
    • Frank Nägler +1
    • Ralf Zimmermann +1
  • Verified V +2
    • Alexander Opitz +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Susi Moog uploaded patch set 1 03/15/18, 21:20

  2. TYPO3com voted on patch set 1 V +1 03/15/18, 21:36 Completed build in 16m 25s on Thu, 15 Mar, 10:36 PM Test Summary: 58213 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2120

  3. Stephan Großberndt commented on patch set 1 04/03/18, 15:49

    ping
  4. Susi Moog commented on patch set 1 04/04/18, 05:09

    Manual backport, needs reviews and tests.
  5. Stephan Großberndt commented on patch set 1 CR +1 04/04/18, 07:06

    Thanks for the info
  6. Ralf Zimmermann voted on patch set 1 CR +1 04/16/18, 07:45

  7. Frank Nägler voted on patch set 1 CR +1 04/26/18, 10:19

  8. Oliver Klee commented on patch set 1 04/26/18, 10:24

    Can we cover this with tests so future changes won't break this?
  9. Frank Nägler commented on patch set 1 V +1 04/26/18, 11:03

    @Oliver: This is a backport, so no additional tests in this patch. but feel free to add tests for this this change in an own patch.
  10. Alexander Opitz voted on patch set 1 V +2 CR +2 05/02/18, 12:35

  11. Alexander Opitz merged patch set 2 05/02/18, 12:35