Review main Merged

56242[TASK] Make TextfieldViewHelperTest notice free

Jan Helke CR +2 V +2 Easy +6 −10 updated 03/16/18, 19:25

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Jan Helke uploaded patch set 1 03/16/18, 16:43

  2. TYPO3com voted on patch set 1 V -1 03/16/18, 16:57 Completed build in 14m 03s on Fri, 16 Mar, 05:57 PM Test Summary: 3 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21280

  3. Jan Helke rebased onto patch set 2 03/16/18, 17:04

  4. TYPO3com voted on patch set 2 V +1 03/16/18, 17:20 Completed build in 15m 10s on Fri, 16 Mar, 06:20 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21292

  5. Christian Kuhn commented on patch set 2 03/16/18, 18:50

    AbstractFormFieldViewHelper.php:121

    ?? '' would be less ugly.
  6. Jan Helke uploaded patch set 3 03/16/18, 18:51

  7. TYPO3com voted on patch set 3 V +1 03/16/18, 19:01 Completed build in 09m 09s on Fri, 16 Mar, 08:01 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21316

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 03/16/18, 19:23

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 03/16/18, 19:25

  10. Christian Kuhn merged patch set 4 03/16/18, 19:25