Review main Merged

56250[TASK] Make PageViewHelperTest notice free

Jan Helke CR +2 V +2 Easy +15 −18 updated 10/11/18, 20:03

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Jan Helke uploaded patch set 1 03/16/18, 19:07

  2. TYPO3com voted on patch set 1 V +1 03/16/18, 19:16 Completed build in 09m 35s on Fri, 16 Mar, 08:16 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21318

  3. Christian Kuhn commented on patch set 1 CR -1 03/16/18, 19:23

    PageViewHelper.php:83

    Typo pageType
  4. Christian Kuhn commented on patch set 1 03/16/18, 19:25

    PageViewHelper.php:85

    sure about fallback true?
  5. Jan Helke uploaded patch set 2 03/16/18, 19:32

  6. Jan Helke commented on patch set 1 03/16/18, 19:33

    PageViewHelper.php:83 Reply

    Done

    PageViewHelper.php:85 Reply

    Done
  7. TYPO3com voted on patch set 2 V +1 03/16/18, 19:41 Completed build in 09m 02s on Fri, 16 Mar, 08:41 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21326

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 03/16/18, 19:54

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 03/16/18, 20:24

  10. Christian Kuhn merged patch set 3 03/16/18, 20:24

  11. Georg Ringer commented on patch set 3 10/11/18, 19:45

    just a post review: it forces now the pageUid to be an integer, string have been possible before
  12. Benjamin Franzke commented on patch set 3 10/11/18, 20:03

    Which is good as the pageUid argument has always been specified as integer, not as mixed: $this->registerArgument('pageUid', 'int', 'Target page. See TypoLink destination');