Review main Abandoned

56254[WIP][TASK] Drop $GLOBALS['SOBE'] in NewRecordController

Mathias Brodala CR 0 V 0 Normal +87 −7 updated 05/31/19, 12:42

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 79

  1. Mathias Brodala uploaded patch set 1 03/16/18, 19:53

  2. TYPO3com voted on patch set 1 V -1 03/16/18, 19:53 Completed build in 11s on Fri, 16 Mar, 08:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21332

  3. Mathias Brodala uploaded patch set 2 03/16/18, 19:55

  4. TYPO3com voted on patch set 2 V +1 03/16/18, 20:04 Completed build in 09m 05s on Fri, 16 Mar, 09:04 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21333

  5. Christian Kuhn commented on patch set 2 CR -1 03/16/18, 20:13

    don't like the solution much - we'll think about possible other solutions later.
  6. Benni Mack commented on patch set 2 09/03/18, 09:14

    when is later(tm)?
  7. Christian Kuhn commented on patch set 2 CR 0 09/03/18, 11:18

    removing -1. i however think the solution is pretty excessive to just communicate an id from one class to another. there should be some easier solution that does not need a new extending class and a bunch of getters & setters.
  8. Mathias Brodala commented on patch set 2 09/03/18, 11:21

    > removing -1. i however think the solution is pretty excessive to > just communicate an id from one class to another. there should be > some easier solution that does not need a new extending class and a > bunch of getters & setters. Maybe the consumer could prepare the treeview and inject it as dependency into the position map ...
  9. Mathias Brodala abandoned the change 05/31/19, 12:42

    still TODO but needs to be done from scratch