5627[BUGFIX] Workspace preview link shows Admin-Panel
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 22
-
Markus Klein uploaded patch set 3 04/05/13, 22:14
-
Markus Klein commented on patch set 3 04/05/13, 22:14
4.7 rebase -
Oliver Hader commented on patch set 2 04/05/13, 22:14
Rebasing to master V:0, R:0 -
Oliver Hader uploaded patch set 2 04/05/13, 22:14
-
Steffen Ritter commented on patch set 3 04/05/13, 22:14
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 3 04/05/13, 22:14
you could do it on 4.6 :) patch are equal.. but you're right, quite difficult on master right now! -
Philipp Gampe commented on patch set 3 04/05/13, 22:14
(1 inline comment)class.tslib_fe.php:645whitespace issue -
Philipp Gampe commented on patch set 3 04/05/13, 22:14
Any hint how to create a preview link with brocken WS module? Or can I do this somewhere else? -
Markus Klein commented on patch set 5 04/05/13, 22:14
No score -
Markus Klein uploaded patch set 5 04/05/13, 22:14
-
Markus Klein commented on patch set 5 04/05/13, 22:14
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 04/05/13, 22:14
Note: I did also review on 4-6. -
Philipp Gampe uploaded patch set 4 04/05/13, 22:14
-
Philipp Gampe commented on patch set 4 04/05/13, 22:14
Verified; Looks good to me, but someone else must approve I just removed a space at EOL. After generation link in 4-6, I could do the review on master. -
Philipp Gampe commented on patch set 5 04/05/13, 22:14
Fails no admin panel is show ever now. With the chuck from patchset 4, it is shown, but is brocken: Fatal error: Call to undefined method stdClass::writeUC() -
Philipp Gampe commented on patch set 5 04/05/13, 22:14
This class needs a $GLOBALS['BE_USER'] object in place. Solution is to just copy the $BE_USER there. Makes Admin Panel work if explicitly requested via &ADMCMD_view=1 However the normal TS setting for the admin panel does not work any more. So this patch need further work. -
Mr. Jenkins commented on patch set 1 04/05/13, 22:14
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/2042/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/05/13, 22:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2698/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/05/13, 22:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2786/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/05/13, 22:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2805/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/05/13, 22:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3140/ : SUCCESS -
Benni Mack commented on patch set 5 04/05/13, 22:14
Abandoned Need to rediscuss with Helmut.