Review main Abandoned

5627[BUGFIX] Workspace preview link shows Admin-Panel

Benni Mack CR 0 V 0 Easy +4 −6 updated 06/03/13, 20:49

Commit message

If the admin, who created a workspace preview link, has an enabled
admin panel, the generated preview link also shows the admin panel.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 22

  1. Markus Klein uploaded patch set 3 04/05/13, 22:14

  2. Markus Klein commented on patch set 3 04/05/13, 22:14

    4.7 rebase
  3. Oliver Hader commented on patch set 2 04/05/13, 22:14

    Rebasing to master V:0, R:0
  4. Oliver Hader uploaded patch set 2 04/05/13, 22:14

  5. Steffen Ritter commented on patch set 3 04/05/13, 22:14

    Looks good to me, but someone else must approve
  6. Steffen Ritter commented on patch set 3 04/05/13, 22:14

    you could do it on 4.6 :) patch are equal.. but you're right, quite difficult on master right now!
  7. Philipp Gampe commented on patch set 3 04/05/13, 22:14

    (1 inline comment)

    class.tslib_fe.php:645

    whitespace issue
  8. Philipp Gampe commented on patch set 3 04/05/13, 22:14

    Any hint how to create a preview link with brocken WS module? Or can I do this somewhere else?
  9. Markus Klein commented on patch set 5 04/05/13, 22:14

    No score
  10. Markus Klein uploaded patch set 5 04/05/13, 22:14

  11. Markus Klein commented on patch set 5 04/05/13, 22:14

    Looks good to me, but someone else must approve
  12. Philipp Gampe commented on patch set 4 04/05/13, 22:14

    Note: I did also review on 4-6.
  13. Philipp Gampe uploaded patch set 4 04/05/13, 22:14

  14. Philipp Gampe commented on patch set 4 04/05/13, 22:14

    Verified; Looks good to me, but someone else must approve I just removed a space at EOL. After generation link in 4-6, I could do the review on master.
  15. Philipp Gampe commented on patch set 5 04/05/13, 22:14

    Fails no admin panel is show ever now. With the chuck from patchset 4, it is shown, but is brocken: Fatal error: Call to undefined method stdClass::writeUC()
  16. Philipp Gampe commented on patch set 5 04/05/13, 22:14

    This class needs a $GLOBALS['BE_USER'] object in place. Solution is to just copy the $BE_USER there. Makes Admin Panel work if explicitly requested via &ADMCMD_view=1 However the normal TS setting for the admin panel does not work any more. So this patch need further work.
  17. Mr. Jenkins commented on patch set 1 04/05/13, 22:14

  18. Mr. Jenkins commented on patch set 2 04/05/13, 22:14

  19. Mr. Jenkins commented on patch set 3 04/05/13, 22:14

  20. Mr. Jenkins commented on patch set 4 04/05/13, 22:14

  21. Mr. Jenkins commented on patch set 5 04/05/13, 22:14

  22. Benni Mack commented on patch set 5 04/05/13, 22:14

    Abandoned Need to rediscuss with Helmut.