Review main Merged

56275[TASK] Move class RecordList to Controller/RecordListController

Christian Kuhn CR +2 V +2 Normal +82 −18 updated 03/17/18, 10:23

Commit message

Class TYPO3\CMS\Recordlist\RecordList is the list module
main controller and thus should be rename to
TYPO3\CMS\Recordlist\Controller\RecordListController

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 79

  1. Christian Kuhn uploaded patch set 1 03/17/18, 09:18

  2. TYPO3com voted on patch set 1 V +1 03/17/18, 09:27 Completed build in 09m 21s on Sat, 17 Mar, 10:27 AM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21388

  3. Mathias Brodala commented on patch set 2 03/17/18, 09:36

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V +1 03/17/18, 09:45 Completed build in 09m 14s on Sat, 17 Mar, 10:45 AM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21393

  5. Mathias Brodala commented on patch set 2 V +1 CR +1 03/17/18, 09:49

    List module still works as well as search in list and page module. It also works when registering the old class name as module.
  6. Stefan Neufeind voted on patch set 2 CR +1 03/17/18, 10:16

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 03/17/18, 10:22

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 03/17/18, 10:23

  9. Christian Kuhn merged patch set 3 03/17/18, 10:23