Review main Merged

56292[TASK] Escape reserved characters in yaml files

Anja Leichsenring CR +2 V +2 Easy +23 −1 updated 03/17/18, 13:02

Commit message

In preparation to update the symfony/yaml dependency to v4,
proper escaping needs to take place.
Following
http://symfony.com/doc/current/components/yaml/yaml_format.html#strings
unsufficient escaping will result in a parse error.

Review

  • Code review CR +2
    • Jan Helke +2
    • Christian Kuhn +1
  • Verified V +2
    • Jan Helke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 711

  1. Anja Leichsenring uploaded patch set 1 03/17/18, 11:39

  2. Anja Leichsenring uploaded patch set 2 03/17/18, 11:41

  3. TYPO3com voted on patch set 1 V +1 03/17/18, 11:51 Completed build in 10m 59s on Sat, 17 Mar, 12:51 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21431

  4. TYPO3com voted on patch set 2 V +1 03/17/18, 11:51 Completed build in 10m 25s on Sat, 17 Mar, 12:51 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21432

  5. Christian Kuhn uploaded patch set 3 03/17/18, 12:45

  6. Christian Kuhn uploaded patch set 4 03/17/18, 12:47

  7. Christian Kuhn voted on patch set 4 V +1 CR +1 03/17/18, 12:47

  8. TYPO3com voted on patch set 4 V +1 03/17/18, 12:59 Completed build in 12m 27s on Sat, 17 Mar, 01:59 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21455

  9. TYPO3com voted on patch set 3 V +1 03/17/18, 13:02 Completed build in 16m 38s on Sat, 17 Mar, 02:02 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21454

  10. Jan Helke voted on patch set 4 V +2 CR +2 03/17/18, 13:02

  11. Jan Helke merged patch set 5 03/17/18, 13:02