Review main Merged

56303[TASK] Update codeception to 2.4.0

Anja Leichsenring CR +2 V +2 Hard +309 −263 updated 03/17/18, 16:52

Commit message

composer update codeception/codeception --with-dependencies

This comes with a bunch of dependencies also updated, most
important probably: phpunit/phpunit 6.5.0.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 610

  1. Anja Leichsenring uploaded patch set 1 03/17/18, 13:24

  2. TYPO3com voted on patch set 1 V -1 03/17/18, 13:33 Completed build in 09m 42s on Sat, 17 Mar, 02:33 PM Test Summary: 1 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21469

  3. TYPO3com commented on patch set 1 03/17/18, 13:41 Completed build in 26m 46s on Sat, 17 Mar, 02:41 PM Test Summary: 1 of 31013 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21469

  4. Anja Leichsenring uploaded patch set 2 03/17/18, 13:47

  5. TYPO3com voted on patch set 2 V +1 03/17/18, 13:56 Completed build in 08m 39s on Sat, 17 Mar, 02:56 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21471

  6. Anja Leichsenring updated the commit message in patch set 3 03/17/18, 15:57

  7. TYPO3com voted on patch set 3 V +1 03/17/18, 16:08 Completed build in 10m 40s on Sat, 17 Mar, 05:08 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21516

  8. Mathias Brodala commented on patch set 3 V +1 CR +1 03/17/18, 16:50

    The switch to SkippedTestError requires PHPUnit 6.0 or newer which is covered by the typo3/testing-framework dependency.
  9. Christian Kuhn voted on patch set 3 V +2 CR +2 03/17/18, 16:52

  10. Christian Kuhn merged patch set 4 03/17/18, 16:52