Review main Merged

56307[TASK] Extract request processing from RsaEncryptionEncoder

Mathias Brodala CR +2 V +2 Normal +164 −21 updated 03/20/18, 11:53

Commit message

* Deprecate now unused methods
* Update JavaScript to properly use JSON objects

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1722

  1. Mathias Brodala uploaded patch set 1 03/17/18, 14:06

  2. TYPO3com voted on patch set 1 V -1 03/17/18, 14:07 Completed build in 09s on Sat, 17 Mar, 03:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21476

  3. Mathias Brodala uploaded patch set 2 03/18/18, 08:57

  4. Mathias Brodala uploaded patch set 3 03/18/18, 09:00

  5. Mathias Brodala uploaded patch set 4 03/18/18, 09:04

  6. TYPO3com voted on patch set 2 V +1 03/18/18, 09:07 Completed build in 10m 39s on Sun, 18 Mar, 10:07 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21595

  7. TYPO3com voted on patch set 3 V +1 03/18/18, 09:10 Completed build in 10m 03s on Sun, 18 Mar, 10:10 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21596

  8. TYPO3com voted on patch set 4 V +1 03/18/18, 09:13 Completed build in 08m 35s on Sun, 18 Mar, 10:13 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21597

  9. Andreas Kienast commented on patch set 4 CR -1 03/18/18, 09:18

    IIRC you have to rebuild that WithLib.min.js foo. Please see the latest commits in EXT:rsaauth for the exact uglify command.
  10. Mathias Brodala uploaded patch set 5 03/18/18, 09:34

  11. Mathias Brodala commented on patch set 5 03/18/18, 09:34

    > IIRC you have to rebuild that WithLib.min.js foo. Please see the > latest commits in EXT:rsaauth for the exact uglify command. Done, thanks for the hint.
  12. TYPO3com voted on patch set 5 V +1 03/18/18, 09:44 Completed build in 09m 47s on Sun, 18 Mar, 10:44 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21604

  13. Anja Leichsenring voted on patch set 5 V +1 CR +1 03/18/18, 12:20

  14. Benni Mack voted on patch set 5 CR +2 03/19/18, 20:01

  15. Benni Mack voted on patch set 5 V +2 03/20/18, 06:15

  16. Benni Mack merged patch set 6 03/20/18, 06:15

  17. Nicole Hummel commented on patch set 6 03/20/18, 10:07

    Post -1. You deprecated public api that was meant to be used outside from core without any substitution. Furthermore I don't understand why there are deprecations added in an extension that is already deprecated itself.

    RsaEncryptionEncoder.php:97

    This now deprecated the only public api usage without request/response objects. There is no way to fetch a key in an own extension anymore. I would recommend to remove the deprecation again, because RsaEncryptionEncoder and RsaEncryptionDecoder are meant to be used outside the core as well.
  18. Mathias Brodala commented on patch set 6 03/20/18, 10:13

    > (1 comment) > > Post -1. You deprecated public api that was meant to be used > outside from core without any substitution. Furthermore I don't > understand why there are deprecations added in an extension that is > already deprecated itself. There is a substitute or more what people actually should have used from the start: the public backend API of rsaauth. This change was done since it was not yet decided if rsaauth will be removed in v9 or v10 and the current main goal is to clean up TYPO3 for proper PSR-7 usage.

    RsaEncryptionEncoder.php:97 Reply

    Did you have a look at the bundled RST files? Quote: > Extensions should not use the deprecated methods but directly request a key pair via the RSA backend API.
  19. Nicole Hummel commented on patch set 6 03/20/18, 11:08

    RsaEncryptionEncoder.php:97 Reply

    The backend api only returns a key but doesn't store the private key anywhere. Removing this function and make people use Backend\BackendFactory::getBackend() on their own, enforces them to copy & paste this code into their own logic. Sorry, but this doesn't make any sense to me.
  20. Mathias Brodala commented on patch set 6 03/20/18, 11:13

    RsaEncryptionEncoder.php:97 Reply

    Sorry, seems like I didn't get what you mean. You are right, that this method is indeed unrelated to the deprecated request handling below. I'll push another change which cleans this up.
  21. Mathias Brodala commented on patch set 6 03/20/18, 11:37

    RsaEncryptionEncoder.php:97 Reply

  22. Nicole Hummel commented on patch set 6 03/20/18, 11:53

    Thank you!