Review main Merged

56316[TASK] Rename ImageManipulationWizard to ImageManipulationController

Mathias Brodala CR +2 V +2 Normal +62 −9 updated 03/18/18, 11:08

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1215

  1. Mathias Brodala uploaded patch set 1 03/17/18, 14:55

  2. TYPO3com voted on patch set 1 V +1 03/17/18, 15:04 Completed build in 09m 00s on Sat, 17 Mar, 04:04 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21497

  3. Mathias Brodala uploaded patch set 2 03/17/18, 15:36

  4. Christian Kuhn commented on patch set 1 03/17/18, 15:36

    double rename.

    Deprecation-84409-ImageManipulationWizardRenamedToImageManipulationController.rst:20

    the comma is misplaced.
  5. Mathias Brodala commented on patch set 1 03/17/18, 15:38

    Reply

    Done

    Deprecation-84409-ImageManipulationWizardRenamedToImageManipulationController.rst:20 Reply

    Done
  6. Mathias Brodala uploaded patch set 3 03/17/18, 15:38

  7. TYPO3com voted on patch set 2 V +1 03/17/18, 15:46 Completed build in 10m 21s on Sat, 17 Mar, 04:46 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21509

  8. TYPO3com voted on patch set 3 V +1 03/17/18, 15:49 Completed build in 10m 36s on Sat, 17 Mar, 04:49 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21510

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 03/17/18, 15:58

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 03/17/18, 16:28

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 03/17/18, 16:28

  12. Christian Kuhn merged patch set 4 03/17/18, 16:28

  13. Frans Saris commented on patch set 4 03/18/18, 10:08

    Why isn't this change marked as breaking? If you extend the wizard the classmap doesn't help does it?
  14. Mathias Brodala commented on patch set 4 03/18/18, 10:30

    > Why isn't this change marked as breaking? If you extend the wizard > the classmap doesn't help does it? It does, see https://github.com/TYPO3/class-alias-loader/blob/7ef8abc/src/ClassAliasLoader.php#L172 and https://secure.php.net/class_alias and https://3v4l.org/AnWQK
  15. Frans Saris commented on patch set 4 03/18/18, 11:08

    Ok, tnx for clarifying this. Learned something today :)