56316[TASK] Rename ImageManipulationWizard to ImageManipulationController
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.phprenamed+4 −4
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+1 −1
- typo3/sysext/backend/Migrations/Code/ClassAliasMap.php+1 −0
- typo3/sysext/backend/Migrations/Code/LegacyClassesForIde.php+12 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84399-ClassRecordListRenamedToRecordListController.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84409-ImageManipulationWizardRenamedToImageManipulationController.rst2new+35 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84410-CodeCompletionRenamedToCodeCompletionController.rst+2 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 1215
-
Mathias Brodala uploaded patch set 1 03/17/18, 14:55
-
TYPO3com voted on patch set 1 V +1 03/17/18, 15:04 Completed build in 09m 00s on Sat, 17 Mar, 04:04 PM Test Summary: 30861 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21497
-
Mathias Brodala uploaded patch set 2 03/17/18, 15:36
-
Christian Kuhn commented on patch set 1 03/17/18, 15:36
double rename.Deprecation-84409-ImageManipulationWizardRenamedToImageManipulationController.rst:20the comma is misplaced. -
Mathias Brodala commented on patch set 1 03/17/18, 15:38
Reply
DoneDeprecation-84409-ImageManipulationWizardRenamedToImageManipulationController.rst:20ReplyDone -
Mathias Brodala uploaded patch set 3 03/17/18, 15:38
-
TYPO3com voted on patch set 2 V +1 03/17/18, 15:46 Completed build in 10m 21s on Sat, 17 Mar, 04:46 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21509
-
TYPO3com voted on patch set 3 V +1 03/17/18, 15:49 Completed build in 10m 36s on Sat, 17 Mar, 04:49 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21510
-
Christian Kuhn voted on patch set 3 V +1 CR +1 03/17/18, 15:58
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 03/17/18, 16:28
-
Christian Kuhn voted on patch set 3 V +2 CR +2 03/17/18, 16:28
-
Christian Kuhn merged patch set 4 03/17/18, 16:28
-
Frans Saris commented on patch set 4 03/18/18, 10:08
Why isn't this change marked as breaking? If you extend the wizard the classmap doesn't help does it? -
Mathias Brodala commented on patch set 4 03/18/18, 10:30
> Why isn't this change marked as breaking? If you extend the wizard > the classmap doesn't help does it? It does, see https://github.com/TYPO3/class-alias-loader/blob/7ef8abc/src/ClassAliasLoader.php#L172 and https://secure.php.net/class_alias and https://3v4l.org/AnWQK -
Frans Saris commented on patch set 4 03/18/18, 11:08
Ok, tnx for clarifying this. Learned something today :)