Review main Merged

56321[TASK] Extract request processing from IconFactory

Mathias Brodala CR +2 V +2 Normal +66 −26 updated 03/17/18, 17:11

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Mathias Brodala uploaded patch set 1 03/17/18, 15:58

  2. TYPO3com voted on patch set 1 V -1 03/17/18, 15:59 Completed build in 13s on Sat, 17 Mar, 04:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21517

  3. Mathias Brodala uploaded patch set 2 03/17/18, 16:03

  4. TYPO3com voted on patch set 2 V +1 03/17/18, 16:13 Completed build in 09m 40s on Sat, 17 Mar, 05:13 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21519

  5. Mathias Brodala commented on patch set 3 03/17/18, 16:57

    Published edit on patch set 2.
  6. Anja Leichsenring voted on patch set 3 V +1 CR +1 03/17/18, 16:59

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 03/17/18, 16:59

  8. TYPO3com voted on patch set 3 V +1 03/17/18, 17:10 Completed build in 12m 58s on Sat, 17 Mar, 06:10 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21547

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 03/17/18, 17:11

  10. Christian Kuhn merged patch set 4 03/17/18, 17:11