Review main Merged

56326[BUGFIX] Form editor breaks if property path does not exist

Ralf Zimmermann CR +2 V +2 Easy +22 −0 updated 04/17/18, 21:45

Commit message

If a property path - which should be validated within the form editor -
does not exist within the form definition and this property is not
defined through the 'predefinedDefaults' within the setup, the
form editor must not break.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Björn Jacob +1
    • Kay Strobach +1
  • Verified V +2
    • Benjamin Kott +2
    • Björn Jacob +1
    • Kay Strobach +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Ralf Zimmermann uploaded patch set 1 03/17/18, 16:41

  2. TYPO3com voted on patch set 1 V +1 03/17/18, 16:52 Completed build in 10m 04s on Sat, 17 Mar, 05:52 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21539

  3. Ralf Zimmermann updated the commit message in patch set 2 03/17/18, 17:20

  4. Ralf Zimmermann commented on patch set 2 03/17/18, 17:22

    Look into the ticket for testcase.
  5. Oliver Klee updated the commit message in patch set 3 03/17/18, 17:26

  6. Björn Jacob updated the commit message in patch set 4 03/17/18, 17:27

  7. TYPO3com voted on patch set 2 V +1 03/17/18, 17:36 Completed build in 15m 25s on Sat, 17 Mar, 06:36 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21559

  8. TYPO3com voted on patch set 3 V +1 03/17/18, 17:39 Completed build in 13m 01s on Sat, 17 Mar, 06:39 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21562

  9. TYPO3com voted on patch set 4 V +1 03/17/18, 17:40 Completed build in 13m 27s on Sat, 17 Mar, 06:40 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21564

  10. Kay Strobach voted on patch set 4 V +1 CR +1 04/17/18, 20:51

  11. Björn Jacob voted on patch set 4 V +1 CR +1 04/17/18, 20:52

  12. Benjamin Kott voted on patch set 4 V +2 CR +2 04/17/18, 21:44

  13. Benjamin Kott merged patch set 5 04/17/18, 21:45