Review main Merged

56327[BUGFIX] Make line height configurable for Gifbuilder

Tymoteusz Motylewski CR +2 V +2 Easy +4 −0 updated 03/17/18, 17:14

Commit message

If `lineHeight` is set then its value would be taken
as line height instead of line height calculated from given text.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Tymoteusz Motylewski uploaded patch set 1 03/17/18, 16:50

  2. Tymoteusz Motylewski commented on patch set 1 03/17/18, 16:51

  3. TYPO3com voted on patch set 1 V +1 03/17/18, 17:01 Completed build in 11m 03s on Sat, 17 Mar, 06:01 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21541

  4. Stefan Neufeind voted on patch set 1 CR +1 03/17/18, 17:09

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 03/17/18, 17:11

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/17/18, 17:14

  7. Christian Kuhn merged patch set 2 03/17/18, 17:14

  8. Christian Kuhn commented on patch set 2 03/17/18, 17:14

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 7880c6437d399b59ce09ad760809e8366bfa7303