Review main Merged

56328[BUGFIX] Validation error arguments are not applied

Ralf Zimmermann CR +2 V +2 Normal +72 −7 updated 04/19/18, 13:32

Commit message

If an extbase error object wants to be translated through EXT:form and
no translation is found, the original error message will be shown.
Possibly existing error message arguments must be applied by calling
the error objects __toString() method.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Björn Jacob +1
    • Kay Strobach +1
  • Verified V +2
    • Frank Nägler +2
    • Björn Jacob +1
    • Kay Strobach +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1215

  1. Ralf Zimmermann uploaded patch set 1 03/17/18, 16:50

  2. TYPO3com voted on patch set 1 V -1 03/17/18, 16:51 Completed build in 13s on Sat, 17 Mar, 05:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21542

  3. Ralf Zimmermann uploaded patch set 2 03/17/18, 18:37

  4. Ralf Zimmermann commented on patch set 2 03/17/18, 18:38

    Look into the ticket for a testcase.
  5. TYPO3com voted on patch set 2 V +1 03/17/18, 18:46 Completed build in 08m 37s on Sat, 17 Mar, 07:46 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21571

  6. Mathias Schreiber voted on patch set 2 V +1 CR +1 04/17/18, 19:54

  7. Björn Jacob commented on patch set 3 04/17/18, 20:39

    Published edit on patch set 2.
  8. Björn Jacob voted on patch set 3 V +1 CR +1 04/17/18, 20:40

  9. Kay Strobach voted on patch set 3 V +1 CR +1 04/17/18, 20:40

  10. TYPO3com voted on patch set 3 V +1 04/17/18, 20:52 Completed build in 12m 28s on Tue, 17 Apr, 10:52 PM Test Summary: 30986 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22505

  11. Benjamin Kott commented on patch set 3 CR -1 04/17/18, 21:58

    need to talk to ralf, porting this to 8.7 is can be considered as breaking due a partial change
  12. Björn Jacob commented on patch set 3 04/19/18, 13:08

    We decided to have this patch in v8 as well. But we will manually backport this patch and remove the deprecation. The patch is backwards compatible and will not harm existing templates.
  13. Benjamin Kott voted on patch set 3 CR 0 04/19/18, 13:10

  14. Frank Nägler voted on patch set 3 V +2 CR +2 04/19/18, 13:32

  15. Frank Nägler merged patch set 4 04/19/18, 13:32