56331[TASK] Extract request processing from ShortcutToolbarItem
Commit message
Review
-
Code review CR +2
- Mathias Brodala +2
- Anja Leichsenring +1
- Robert van Kammen +1
- Jörg Bösche +1
-
Verified V +2
- Mathias Brodala +2
- Anja Leichsenring +1
- Robert van Kammen +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php14new+785 −0
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+46 −822
- typo3/sysext/backend/Classes/Controller/ShortcutController.phpnew+198 −0
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+3 −1
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+3 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+8 −19
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+5 −5
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-84414-BackendUtilityshortcutExists.rstnew+32 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 3962
Show 2037 earlier messages
-
Mathias Brodala uploaded patch set 1 03/17/18, 17:17
-
Mathias Brodala uploaded patch set 2 03/17/18, 17:24
-
TYPO3com voted on patch set 2 V -1 03/17/18, 17:25 Completed build in 13s on Sat, 17 Mar, 06:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21560
-
Mathias Brodala uploaded patch set 3 03/17/18, 17:26
-
TYPO3com voted on patch set 1 V +1 03/17/18, 17:30 Completed build in 13m 46s on Sat, 17 Mar, 06:30 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21557
-
TYPO3com voted on patch set 3 V +1 03/17/18, 17:40 Completed build in 13m 39s on Sat, 17 Mar, 06:40 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21563
-
Mathias Brodala uploaded patch set 4 03/17/18, 17:43
-
TYPO3com voted on patch set 4 V -1 03/17/18, 17:43 Completed build in 10s on Sat, 17 Mar, 06:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21565
-
Benni Mack commented on patch set 4 03/17/18, 22:09
just name it to "BookmarkRepository", there was a WIP Patch where we wanted to move everything from shortcuts to bookmarks in all the places, and we also started with a BookmarkRepository - however this patch was never finished and is now quite breaking, so I'd opt for just naming it BookmarkRepository and we can continue on this basis when migrating the rest. -
Mathias Brodala wrote 05/17/18, 09:06
Topic set to PSR-7 -
Mathias Brodala rebased onto patch set 5 06/21/18, 15:11
-
TYPO3com voted on patch set 5 V -1 06/21/18, 15:11 Completed build in 08s on Thu, 21 Jun, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24590
-
Mathias Brodala uploaded patch set 6 06/21/18, 16:06
-
TYPO3com voted on patch set 6 V -1 06/21/18, 16:06 Completed build in 07s on Thu, 21 Jun, 06:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24591
-
Mathias Brodala uploaded patch set 7 06/21/18, 19:42
-
TYPO3com voted on patch set 7 V -1 06/21/18, 19:50 Completed build in 08m 03s on Thu, 21 Jun, 09:50 PM Test Summary: 3 of 32950 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24593
-
Mathias Brodala uploaded patch set 8 06/21/18, 20:10
-
TYPO3com voted on patch set 8 V +1 06/21/18, 20:18 Completed build in 08m 11s on Thu, 21 Jun, 10:18 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24594
-
Mathias Brodala uploaded patch set 9 06/21/18, 20:22
-
TYPO3com voted on patch set 9 V +1 06/21/18, 20:31 Completed build in 08m 57s on Thu, 21 Jun, 10:31 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24595
-
Mathias Brodala uploaded patch set 10 06/21/18, 21:15
-
TYPO3com voted on patch set 10 V +1 06/21/18, 21:23 Completed build in 08m 22s on Thu, 21 Jun, 11:23 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24597
-
Mathias Brodala uploaded patch set 11 06/22/18, 07:21
-
TYPO3com voted on patch set 11 V +1 06/22/18, 07:29 Completed build in 08m 23s on Fri, 22 Jun, 09:29 AM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24600
-
Mathias Brodala uploaded patch set 12 06/22/18, 12:45
-
TYPO3com voted on patch set 12 V -1 06/22/18, 12:45 Completed build in 08s on Fri, 22 Jun, 02:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24607
-
Mathias Brodala uploaded patch set 13 06/22/18, 13:49
-
TYPO3com voted on patch set 13 V -1 06/22/18, 13:49 Completed build in 08s on Fri, 22 Jun, 03:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24612
-
Mathias Brodala uploaded patch set 14 06/22/18, 13:50
-
Mathias Brodala uploaded patch set 15 06/22/18, 13:55
-
TYPO3com voted on patch set 15 V -1 06/22/18, 13:55 Completed build in 09s on Fri, 22 Jun, 03:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24614
-
TYPO3com voted on patch set 14 V +1 06/22/18, 13:58 Completed build in 07m 58s on Fri, 22 Jun, 03:58 PM Test Summary: 32702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24613
-
Mathias Brodala uploaded patch set 16 06/22/18, 14:48
-
TYPO3com voted on patch set 16 V -1 06/22/18, 14:48 Completed build in 07s on Fri, 22 Jun, 04:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24621
-
Mathias Brodala uploaded patch set 17 06/22/18, 15:21
-
Mathias Brodala uploaded patch set 18 06/22/18, 15:23
-
TYPO3com voted on patch set 18 V -1 06/22/18, 15:23 Completed build in 14s on Fri, 22 Jun, 05:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24626
-
Mathias Brodala uploaded patch set 19 06/22/18, 15:29
-
TYPO3com voted on patch set 17 V +1 06/22/18, 15:29 Completed build in 07m 59s on Fri, 22 Jun, 05:29 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24625
-
TYPO3com voted on patch set 19 V +1 06/22/18, 15:37 Completed build in 08m 42s on Fri, 22 Jun, 05:37 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24627
-
Presedo Roberto voted on patch set 19 V +1 CR +1 06/22/18, 20:45
-
Susi Moog commented on patch set 19 CR -1 06/22/18, 20:58
ShortcutRepository.php:82this construct is weird. you initialize a var you directly overwrite because of 'invisible' coupling between the class var and the method (which directly manipulates the shortcutGroups and returns them to then overwrite the class var..)ShortcutRepository.php:690use strpos === 0 instead -
Mathias Brodala commented on patch set 19 06/22/18, 21:08
ShortcutRepository.php:82ReplyThat's true but TBH I just moved over that method. I'll have another look.ShortcutRepository.php:690ReplyWill do. -
Mathias Brodala uploaded patch set 20 06/22/18, 21:30
-
TYPO3com voted on patch set 20 V +1 06/22/18, 21:47 Completed build in 16m 27s on Fri, 22 Jun, 11:47 PM Test Summary: 32705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24695
-
Frank Nägler commented on patch set 20 CR -1 06/22/18, 23:48
ShortcutRepository.php:231could be simplified: /^[\d]+:/ShortcutRepository.php:292Variabel $success is redundant, direct return is possible hereShortcutRepository.php:335same hereShortcutRepository.php:404$groups is redundant, iteration with $shortcutGroups is possible hereShortcutRepository.php:611$this->fieldArray is not defined -
Mathias Brodala wrote 06/23/18, 09:10
Topic PSR-7 removed -
Mathias Brodala commented on patch set 20 06/23/18, 09:20
ShortcutRepository.php:231ReplyDoneShortcutRepository.php:292ReplyDoneShortcutRepository.php:335ReplyDoneShortcutRepository.php:404ReplyDoneShortcutRepository.php:611ReplyApparently that was already the case when this was added: https://github.com/TYPO3/TYPO3.CMS/commit/b608cd079479797a818dbb6a032f06b1acbb9275 I'll drop it. -
Mathias Brodala uploaded patch set 21 06/23/18, 09:22
-
TYPO3com voted on patch set 21 V +1 06/23/18, 09:31 Completed build in 09m 30s on Sat, 23 Jun, 11:31 AM Test Summary: 32723 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24740
-
Mathias Brodala uploaded patch set 22 06/29/18, 08:15
-
TYPO3com voted on patch set 22 V +1 06/29/18, 08:28 Completed build in 12m 57s on Fri, 29 Jun, 10:28 AM Test Summary: 32873 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24977
-
Robert van Kammen commented on patch set 22 V -1 07/06/18, 12:10
In review -
Robert van Kammen voted on patch set 22 V +1 CR +1 07/06/18, 12:19
-
Anja Leichsenring commented on patch set 22 CR -1 07/06/18, 12:26
deprecation rst missing. Will add it. -
Anja Leichsenring uploaded patch set 23 07/06/18, 12:49
-
TYPO3com voted on patch set 23 V +1 07/06/18, 12:57 Completed build in 07m 53s on Fri, 6 Jul, 02:57 PM Test Summary: 32877 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-25152
-
Anja Leichsenring voted on patch set 23 V +1 CR +1 07/06/18, 13:05
-
Robert van Kammen voted on patch set 23 V +1 CR +1 07/06/18, 13:50
-
Jörg Bösche voted on patch set 23 CR +1 07/18/18, 06:51
-
Mathias Brodala voted on patch set 23 V +2 CR +2 07/18/18, 07:33
-
Mathias Brodala merged patch set 24 07/18/18, 07:49