Review main Abandoned

56333[BUGFIX] Remove round from stdWrapOrder

Stefan Froemken CR 0 V 0 Easy +0 −1 updated 03/19/18, 10:56

Commit message

TypoScript property round does not have any
value and it does not have a boolean value as default.
As round will only work with sub-properties,
the value "round" has to be removed from
stdWrapOrder listing.
"round." as array is still valid and has to be untouched.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Stefan Froemken uploaded patch set 1 03/17/18, 18:28

  2. TYPO3com voted on patch set 1 V +1 03/17/18, 18:37 Completed build in 08m 30s on Sat, 17 Mar, 07:37 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21569

  3. Tobi Kretschmann voted on patch set 1 CR +1 03/19/18, 09:11

  4. Mathias Brodala commented on patch set 1 V +1 CR +1 03/19/18, 10:47

    Do we need an RST which tells people that they can drop "round = 1"?
  5. Mathias Brodala commented on patch set 1 V 0 CR -1 03/19/18, 10:51

    The option "round = 1" is valid since it enables the rounding feature itself.
  6. Stefan Froemken abandoned the change 03/19/18, 10:56

    round has to be 1, to activate that feature in general. So no patch needed.