Review main Merged

56335[TASK] Remove superfluous admin check

Georg Ringer CR +2 V +2 Easy +8 −14 updated 03/18/18, 11:39

Commit message

As the scheduler module is only accessible for admins, there is no need
to check this in the controller.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Georg Ringer uploaded patch set 1 03/17/18, 18:59

  2. TYPO3com voted on patch set 1 V +1 03/17/18, 19:07 Completed build in 08m 15s on Sat, 17 Mar, 08:07 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21572

  3. Stephan Großberndt updated the commit message in patch set 2 03/17/18, 19:27

  4. Stephan Großberndt commented on patch set 2 03/17/18, 19:30

    On mobile currently, just wondering: Is this really safe? Can't a normal user forge a request url to access the scheduler without this check?
  5. TYPO3com voted on patch set 2 V +1 03/17/18, 19:35 Completed build in 07m 40s on Sat, 17 Mar, 08:35 PM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21575

  6. Georg Ringer commented on patch set 2 03/18/18, 07:43

    Not possible
  7. Wouter Wolters voted on patch set 2 CR +1 03/18/18, 10:05

  8. Jan Helke voted on patch set 2 V +1 CR +1 03/18/18, 11:36

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 03/18/18, 11:39

  10. Christian Kuhn merged patch set 3 03/18/18, 11:39