Review main Merged

56342[BUGFIX] Add correct context to page tree context menu

Tymoteusz Motylewski CR +2 V +2 Easy +16 −11 updated 03/19/18, 18:40

Commit message

In order to allow user to disable context menu items for certain context,
e.g. page tree, page tree need to correctly pass the context to the JS.

As SvgTree doesnt support context menu, the code is moved to the PageTree.js
Also a bug in the changelog documentation is fixed.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Tobi Kretschmann +1
    • Łukasz Uznański +1
    • Paweł Rogowicz +1
  • Verified V +2
    • Andreas Kienast +2
    • Paweł Rogowicz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1012

  1. Tymoteusz Motylewski uploaded patch set 1 03/18/18, 08:56

  2. Tymoteusz Motylewski updated the commit message in patch set 2 03/18/18, 08:56

  3. TYPO3com voted on patch set 1 V +1 03/18/18, 09:05 Completed build in 09m 44s on Sun, 18 Mar, 10:05 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21593

  4. TYPO3com voted on patch set 2 V +1 03/18/18, 09:07 Completed build in 10m 59s on Sun, 18 Mar, 10:07 AM Test Summary: 30882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21594

  5. Łukasz Uznański voted on patch set 2 CR +1 03/18/18, 11:57

  6. Tobi Kretschmann voted on patch set 2 CR +1 03/19/18, 09:14

  7. Paweł Rogowicz voted on patch set 2 CR +1 03/19/18, 13:15

  8. Paweł Rogowicz voted on patch set 2 V +1 03/19/18, 13:23

  9. Andreas Kienast voted on patch set 2 CR +1 03/19/18, 17:15

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 03/19/18, 18:37

  11. Andreas Kienast merged patch set 3 03/19/18, 18:37

  12. Andreas Kienast commented on patch set 3 03/19/18, 18:40

    @tymek: can you please take care of the backport?